| Summary: | [Cocoa] ComplexTextController's notion of glyph run initial advance is wrong | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||||
| Status: | RESOLVED WONTFIX | ||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 228905 | ||||||||||||
| Bug Blocks: | 206208 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Myles C. Maxfield
2021-07-22 02:46:31 PDT
Created attachment 434001 [details]
Needs tests
Failing tests on Monterey: fast/ruby/ruby-expansion-cjk-4.html fast/text/combining-enclosing-keycap.html fast/text/initial-advance-in-intermediate-run-complex.html imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html imported/w3c/web-platform-tests/css/css-ui/text-overflow-022.html imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg svg/W3C-I18N/text-anchor-no-markup.svg svg/W3C-SVG-1.1/text-fonts-01-t.svg Created attachment 434031 [details]
Patch
New failing tests: fast/text/combining-enclosing-keycap.html fast/text/initial-advance-in-intermediate-run-complex.html fast/text/initial-advance-selected-text.html imported/blink/fast/gradients/gradient-transparency.html imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html model-element/model-element-source.html platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirLTR-anchorStart.svg svg/W3C-I18N/text-anchor-dirNone-anchorEnd.svg svg/W3C-I18N/text-anchor-dirNone-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirNone-anchorStart.svg svg/W3C-I18N/text-anchor-dirRTL-anchorEnd.svg svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle.svg svg/W3C-I18N/text-anchor-dirRTL-anchorStart.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle.svg svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle.svg svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart.svg svg/W3C-I18N/text-anchor-no-markup.svg svg/dom/altGlyph-dom.xhtml Failing tests: fast/text/combining-enclosing-keycap.html imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html fast/text/initial-advance-in-intermediate-run-complex.html fast/text/initial-advance-selected-text.html imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html fast/text/combining-enclosing-keycap.html and imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html look like rebaselines. fast/text/initial-advance-in-intermediate-run-complex.html needs an update (the test is philosophically passing but being reported as failing) fast/text/initial-advance-in-intermediate-run-complex.html is rdar://80985709. Whoops, this meant to say: fast/text/initial-advance-in-intermediate-run-complex.html needs an update (the test is philosophically passing but being reported as failing) fast/text/initial-advance-selected-text.html is rdar://80985709. See also: rdar://80985709 Created attachment 434966 [details]
WIP
I think I should split this up into 2 patches: 1. Add each run’s initial advance to the end of the previous run 2. The initial advance doesn’t point to the first glyph’s pain location. This one will need the new SPI. Let's not do this. Let's instead just delete the complex text codepath. Reopening to attach new patch. Created attachment 435326 [details]
Patch that does everything right with the SPI
|