Bug 228177

Summary:

[Cocoa] Stop honoring any dot-prefixed font names

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	sam: review+

Myles C. Maxfield

Reported 2021-07-22 01:34:10 PDT

[Cocoa] Stop honoring any dot-prefixed font names

Attachments
Patch (1.76 KB, patch) 2021-07-22 01:34 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (21.09 KB, patch) 2021-07-23 23:22 PDT, Myles C. Maxfield	sam: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2021-07-22 01:34:29 PDT

Created attachment 433997 [details] Patch

Myles C. Maxfield

Comment 2 2021-07-22 01:35:19 PDT

This might have to be a linked-on-or-after check, or new SPI.

Myles C. Maxfield

Comment 3 2021-07-22 02:20:42 PDT

Tests that failed on Monterey: fast/text/font-lookup-dot-prefix-case-sensitive.html => This test should be deleted fast/text/trak-optimizeLegibility.html => This test should be investigated svg/dom/altGlyph-dom.xhtml => This is probably a rebaseline.

Myles C. Maxfield

Comment 4 2021-07-22 02:21:54 PDT

(In reply to Myles C. Maxfield from comment #3) > Tests that failed on Monterey: > > fast/text/font-lookup-dot-prefix-case-sensitive.html > => This test should be deleted Actually, not deleted, but the -expected-mismatch should turn into an -expected.

Myles C. Maxfield

Comment 5 2021-07-22 15:38:37 PDT

These same tests are the tests that fail on Big Sur.

Myles C. Maxfield

Comment 6 2021-07-23 23:22:47 PDT

Created attachment 434158 [details] Patch

Myles C. Maxfield

Comment 7 2021-07-24 14:07:07 PDT

Thanks for the review! I can't land this just yet at this point in the release cycle.

Radar WebKit Bug Importer

Comment 8 2021-07-29 01:35:47 PDT

<rdar://problem/81259420>