| Summary: | [Cocoa] Stop treating the system font as a non-variable font | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Myles C. Maxfield
2021-07-22 01:18:34 PDT
Created attachment 433996 [details]
WIP
There are lots of failures on Catalina. On Big Sur, the failures are: fast/text/trak-optimizeLegibility.html fast/text/design-system-ui-7.html So I think this has to be Monterey and later because fast/text/design-system-ui-7.html probably won't be able to be fixed on Big Sur. Created attachment 434118 [details]
Patch
Comment on attachment 434118 [details]
Patch
Oh, I need to make the test only valid on certain OSes.
Created attachment 434154 [details]
Patch
Comment on attachment 434154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434154&action=review > Source/WTF/ChangeLog:8 > + * wtf/PlatformUse.h: This kinda feels like it should be a HAVE_ since it is about whether a specific system feature is available and not a policy about using an optional library or service. Thanks for the review! I can't land this just yet at this point in the release cycle. *** Bug 221223 has been marked as a duplicate of this bug. *** Tools/Scripts/svn-apply failed to apply attachment 434154 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Committed r281291 (240715@main): <https://commits.webkit.org/240715@main> Committed r282044 (241344@main): <https://commits.webkit.org/241344@main> |