Bug 228176

Summary: [Cocoa] Stop treating the system font as a non-variable font
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch sam: review+, ews-feeder: commit-queue-

Myles C. Maxfield
Reported 2021-07-22 01:18:34 PDT
[Cocoa] Stop treating the system font as a non-variable font
Attachments
WIP (2.48 KB, patch)
2021-07-22 01:20 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (18.69 KB, patch)
2021-07-23 14:12 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (21.55 KB, patch)
2021-07-23 18:13 PDT, Myles C. Maxfield 		sam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-07-22 01:20:21 PDT
Created attachment 433996 [details] WIP
Myles C. Maxfield
Comment 2 2021-07-22 01:25:15 PDT
There are lots of failures on Catalina.
Myles C. Maxfield
Comment 3 2021-07-22 13:39:07 PDT
On Big Sur, the failures are: fast/text/trak-optimizeLegibility.html fast/text/design-system-ui-7.html
Myles C. Maxfield
Comment 4 2021-07-22 13:41:04 PDT
So I think this has to be Monterey and later because fast/text/design-system-ui-7.html probably won't be able to be fixed on Big Sur.
Myles C. Maxfield
Comment 5 2021-07-23 14:12:50 PDT
Created attachment 434118 [details] Patch
Myles C. Maxfield
Comment 6 2021-07-23 15:47:06 PDT
Comment on attachment 434118 [details] Patch Oh, I need to make the test only valid on certain OSes.
Myles C. Maxfield
Comment 7 2021-07-23 18:13:34 PDT
Created attachment 434154 [details] Patch
Sam Weinig
Comment 8 2021-07-24 11:06:12 PDT
Comment on attachment 434154 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434154&action=review > Source/WTF/ChangeLog:8 > + * wtf/PlatformUse.h: This kinda feels like it should be a HAVE_ since it is about whether a specific system feature is available and not a policy about using an optional library or service.
Myles C. Maxfield
Comment 9 2021-07-24 14:07:16 PDT
Thanks for the review! I can't land this just yet at this point in the release cycle.
Radar WebKit Bug Importer
Comment 10 2021-07-29 01:19:15 PDT
<rdar://problem/81258915>
Myles C. Maxfield
Comment 11 2021-08-08 14:13:07 PDT
*** Bug 221223 has been marked as a duplicate of this bug. ***
EWS
Comment 12 2021-08-19 18:30:03 PDT
Tools/Scripts/svn-apply failed to apply attachment 434154 [details] to trunk. Please resolve the conflicts and upload a new patch.
Myles C. Maxfield
Comment 13 2021-08-19 20:21:17 PDT
Committed r281291 (240715@main): <https://commits.webkit.org/240715@main>
Myles C. Maxfield
Comment 14 2021-09-03 21:34:57 PDT
Committed r282044 (241344@main): <https://commits.webkit.org/241344@main>
Note You need to log in before you can comment on or make changes to this bug.