Bug 228174

Summary: javaScriptEnabled is wrongly marked as deprecated for all iOS version in Xcode 13 beta3
Product: WebKit Reporter: honma
Component: WebKit APIAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Major CC: achristensen, beidson, cdumez, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Mac (Intel)   
OS: macOS 11   
Attachments:
Description Flags
Test project.
none
Patch v1 none

honma
Reported 2021-07-21 20:33:42 PDT
Created attachment 433986 [details] Test project. According to the documentation, this api is available on iOS 8.0 to 14.0, but after specifying the version with @available attribute on xcode beta3, the following warning still appears when compiling. >'javaScriptEnabled' is deprecated: Use WKWebPagePreferences.allowsContentJavaScript to disable content JavaScript on a per-navigation basis This problem does not exist on beta2. It seems to be a bug introduced by beta3. You can build the attached test project with Xcode 13 beta3 to reproduce.
Attachments
Test project. (60.44 KB, application/zip)
2021-07-21 20:33 PDT, honma 		no flags
Details
Patch v1 (1.99 KB, patch)
2021-07-22 13:58 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-21 21:59:59 PDT
<rdar://problem/80940334>
Alex Christensen
Comment 2 2021-07-22 09:18:55 PDT
This was deprecated in r256715 and the macro was updated in r271813. I'm curious what the WKPreferences.h looked like after javaScriptEnabled in beta2 and beta3.
Brady Eidson
Comment 3 2021-07-22 13:58:07 PDT
Created attachment 434033 [details] Patch v1
Brady Eidson
Comment 4 2021-07-22 14:03:19 PDT
https://trac.webkit.org/changeset/279089/webkit is where we think we got this wrong, for reference.
EWS
Comment 5 2021-07-22 15:45:58 PDT
Committed r280202 (239890@main): <https://commits.webkit.org/239890@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434033 [details].
Note You need to log in before you can comment on or make changes to this bug.