Summary: | REGRESSION: [iOS] ASSERTION FAILED: !m_useCount in WebKit::SandboxExtension::~SandboxExtension() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ayumi_kojima | ||||||
Component: | Media | Assignee: | Jer Noble <jer.noble> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, darin, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | iPhone / iPad | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
ayumi_kojima
2021-07-21 16:54:35 PDT
Updated test expectations https://trac.webkit.org/changeset/280169/webkit Created attachment 434237 [details]
Patch
Comment on attachment 434237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434237&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:59 > + ProxyMap proxies; > + proxies.swap(m_proxies); This is old fashioned. New way to do it would be std::exchange instead. (In reply to Darin Adler from comment #4) > Comment on attachment 434237 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434237&action=review > > > Source/WebKit/GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:59 > > + ProxyMap proxies; > > + proxies.swap(m_proxies); > > This is old fashioned. New way to do it would be std::exchange instead. Fantastic, then it turns into an `auto` declaration, and I don't need the change to the header. Thanks! Created attachment 434243 [details]
Patch
Committed r280326 (239973@main): <https://commits.webkit.org/239973@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434243 [details]. |