Bug 228148

Summary: RunningBoard kills the network process if it is still holding the "holding locked file" assertion upon suspension
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, kkinnunen, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Chris Dumez 2021-07-21 08:22:59 PDT 
The network process should release its FinishTaskUninterruptable assertion when it expires or RunningBoard will kill the process. Note that because the process assertion is released on a hysteresis timer, there are 2 possible cases:
1. The network process is no longer holding locked files, we'll release the assertion and suspend nicely.
2. The network process is still holding locked files despite our best efforts, we'll release the assertion and crash on suspension due to holding locked files.
Comment 1 Chris Dumez 2021-07-21 08:24:50 PDT 
Created attachment 433935 [details]
Patch
Comment 2 Chris Dumez 2021-07-21 11:13:56 PDT 
Created attachment 433944 [details]
Patch
Comment 3 Chris Dumez 2021-07-21 12:31:40 PDT 
Created attachment 433947 [details]
Patch
Comment 4 Chris Dumez 2021-07-21 12:55:57 PDT 
Created attachment 433949 [details]
Patch
Comment 5 EWS 2021-07-21 13:59:34 PDT 
Committed r280160 (239857@main): <https://commits.webkit.org/239857@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433949 [details].
Comment 6 Radar WebKit Bug Importer 2021-07-21 14:00:20 PDT 
<rdar://problem/80916330>