Bug 228134

Summary:

Crash in -[WKWebView takeSnapshotWithConfiguration:completionHandler:] when taking empty snapshots

Product:

WebKit

Reporter:

Aditya Keerthi <akeerthi>

Component:

WebKit API

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	cdumez: review+, cdumez: commit-queue-
Patch for landing	ews-feeder: commit-queue-

Description Aditya Keerthi 2021-07-20 18:19:08 PDT

SSIA

Comment 1 Aditya Keerthi 2021-07-20 18:19:23 PDT

rdar://80146087

Comment 2 Aditya Keerthi 2021-07-20 18:20:54 PDT

Created attachment 433914 [details]
Patch

Comment 3 Chris Dumez 2021-07-21 08:28:33 PDT

Comment on attachment 433914 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433914&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1179
> +        RunLoop::main().dispatch([handler] {

handler = WTFMove(handler) to avoid refcounting churn.

Comment 4 Aditya Keerthi 2021-07-21 08:44:32 PDT

Created attachment 433936 [details]
Patch for landing

Comment 5 EWS 2021-07-21 11:11:33 PDT

Committed r280151 (239848@main): <https://commits.webkit.org/239848@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433936 [details].