Bug 228132

Summary:

Make the 'targetElement' argument of the SVG animators to be a reference

Product:

WebKit

Reporter:

Said Abou-Hallawa <sabouhallawa>

Component:

SVG

Assignee:

Said Abou-Hallawa <sabouhallawa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, ews-watchlist, fmalita, gyuyoung.kim, heycam, pdr, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Said Abou-Hallawa 2021-07-20 16:24:22 PDT

It is clear that many SVG animators functions assume the argument 'targetElement' is not nullptr. Also the caller SVGAnimateElementBase makes sure its targetElement() is not nullptr before calling any of its animator's functions.

Comment 1 Said Abou-Hallawa 2021-07-20 16:31:10 PDT

Created attachment 433907 [details]
Patch

Comment 2 Cameron McCormack (:heycam) 2021-07-20 17:27:14 PDT

Comment on attachment 433907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433907&action=review

Non-reviewer's r=me.

> Source/WebCore/svg/SVGElement.cpp:580
> +        propertyRegistry().setAnimatedPropertyDirty(attributeName, animatedProperty);

(Probably should have been in a separate patch.)

Comment 3 EWS 2021-07-20 20:33:51 PDT

Committed r280123 (239835@main): <https://commits.webkit.org/239835@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433907 [details].

Comment 4 Radar WebKit Bug Importer 2021-07-20 20:34:18 PDT

<rdar://problem/80874381>