Bug 228132

Summary: Make the 'targetElement' argument of the SVG animators to be a reference
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: SVGAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, fmalita, gyuyoung.kim, heycam, pdr, schenney, sergio, simon.fraser, thorton, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Said Abou-Hallawa
Reported 2021-07-20 16:24:22 PDT
It is clear that many SVG animators functions assume the argument 'targetElement' is not nullptr. Also the caller SVGAnimateElementBase makes sure its targetElement() is not nullptr before calling any of its animator's functions.
Attachments
Patch (69.44 KB, patch)
2021-07-20 16:31 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2021-07-20 16:31:10 PDT
Created attachment 433907 [details] Patch
Cameron McCormack (:heycam)
Comment 2 2021-07-20 17:27:14 PDT
Comment on attachment 433907 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433907&action=review Non-reviewer's r=me. > Source/WebCore/svg/SVGElement.cpp:580 > + propertyRegistry().setAnimatedPropertyDirty(attributeName, animatedProperty); (Probably should have been in a separate patch.)
EWS
Comment 3 2021-07-20 20:33:51 PDT
Committed r280123 (239835@main): <https://commits.webkit.org/239835@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433907 [details].
Radar WebKit Bug Importer
Comment 4 2021-07-20 20:34:18 PDT
<rdar://problem/80874381>
Note You need to log in before you can comment on or make changes to this bug.