Bug 228107

Summary: IBeam cursor is horizontal in Mail compose window
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, thorton, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kate Cheney
Reported 2021-07-20 08:13:02 PDT
IBeam cursor is horizontal in Mail compose window
Attachments
Patch (4.44 KB, patch)
2021-07-20 08:15 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch (6.28 KB, patch)
2021-07-20 10:41 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2021-07-20 08:15:38 PDT
Created attachment 433875 [details] Patch
Kate Cheney
Comment 2 2021-07-20 08:16:00 PDT
rdar://80636912
Simon Fraser (smfr)
Comment 3 2021-07-20 10:02:11 PDT
Comment on attachment 433875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433875&action=review > Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:76 > + std::optional<bool> isHorizontalWritingMode; Would it be simpler to just call this isVerticalWritingMode and default to false? That's effectively what the code is doing.
Kate Cheney
Comment 4 2021-07-20 10:37:27 PDT
Comment on attachment 433875 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433875&action=review >> Source/WebKit/Shared/ios/InteractionInformationAtPosition.h:76 >> + std::optional<bool> isHorizontalWritingMode; > > Would it be simpler to just call this isVerticalWritingMode and default to false? That's effectively what the code is doing. Yes, it would be.
Kate Cheney
Comment 5 2021-07-20 10:41:23 PDT
Created attachment 433881 [details] Patch
EWS
Comment 6 2021-07-20 12:44:27 PDT
Committed r280098 (239815@main): <https://commits.webkit.org/239815@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433881 [details].
Note You need to log in before you can comment on or make changes to this bug.