Bug 228106

Summary: [GStreamer] Switch raw GstStructure pointers to GUniquePtr
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch calvaris: review+

Philippe Normand
Reported 2021-07-20 05:47:36 PDT
SSIA
Attachments
Patch (5.58 KB, patch)
2021-07-20 06:33 PDT, Philippe Normand 		calvaris: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-07-20 06:33:15 PDT
Created attachment 433872 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2021-07-20 07:34:32 PDT
Comment on attachment 433872 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433872&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2399 > + m_mediaLocationCurrentIndex = static_cast<int>(gst_value_list_get_size(locations)) -1; Now that we're changing this line, let's fix that - 1 .
Philippe Normand
Comment 3 2021-07-20 08:29:49 PDT
Committed r280080 (239806@main): <https://commits.webkit.org/239806@main>
Radar WebKit Bug Importer
Comment 4 2021-07-20 08:30:17 PDT
<rdar://problem/80840075>
Note You need to log in before you can comment on or make changes to this bug.