Bug 228106

Summary:

[GStreamer] Switch raw GstStructure pointers to GUniquePtr

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Platform

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	calvaris: review+

Description Philippe Normand 2021-07-20 05:47:36 PDT

SSIA

Comment 1 Philippe Normand 2021-07-20 06:33:15 PDT

Created attachment 433872 [details]
Patch

Comment 2 Xabier Rodríguez Calvar 2021-07-20 07:34:32 PDT

Comment on attachment 433872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433872&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2399
> +        m_mediaLocationCurrentIndex = static_cast<int>(gst_value_list_get_size(locations)) -1;

Now that we're changing this line, let's fix that - 1 .

Comment 3 Philippe Normand 2021-07-20 08:29:49 PDT

Committed r280080 (239806@main): <https://commits.webkit.org/239806@main>

Comment 4 Radar WebKit Bug Importer 2021-07-20 08:30:17 PDT

<rdar://problem/80840075>