Bug 228099

Summary:

Use references instead of pointers in WidthIterator::advanceInternal()

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Hironori.Fujii, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	Hironori.Fujii: review+

Description Myles C. Maxfield 2021-07-19 23:41:26 PDT

Use references instead of pointers in WidthIterator::advanceInternal()

Comment 1 Myles C. Maxfield 2021-07-19 23:42:22 PDT

Created attachment 433852 [details]
Patch

Comment 2 Fujii Hironori 2021-07-20 13:23:30 PDT

Comment on attachment 433852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433852&action=review

> Source/WebCore/platform/graphics/WidthIterator.cpp:237
> +        ASSERT(&font);

This ASSERT doesn't looks useful. I think you should remove this ASSERT.

Comment 3 Myles C. Maxfield 2021-07-20 13:39:59 PDT

Thanks for the review!!!

Comment 4 Myles C. Maxfield 2021-07-20 13:40:25 PDT

Committed r280102 (239819@main): <https://commits.webkit.org/239819@main>

Comment 5 Radar WebKit Bug Importer 2021-07-20 13:41:16 PDT

<rdar://problem/80855739>