Bug 228060

Summary:

run-webkit-archive crashes with dyld error

Product:

WebKit

Reporter:

Jed Fox <jed>

Component:

Web Inspector

Assignee:

Patrick Angle <pangle>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, beidson, benjamin, cdumez, cmarcelo, ews-watchlist, hi, inspector-bugzilla-changes, keith_miller, mark.lam, msaboff, pangle, saam, smoley, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Safari 14

Hardware:

Mac (Intel)

OS:

macOS 11

See Also:

https://bugs.webkit.org/show_bug.cgi?id=165351

Bug Depends on:

Bug Blocks:

230103

Attachments:

Description	Flags
Patch v1.0	none

Description Jed Fox 2021-07-18 10:44:33 PDT

I downloaded WebKit Nightly r280019 to prepare to report a bug in Safari Technology Preview. I right-clicked on run-webkit-archive and chose Open to run it. the Terminal app was opened and showed me this:

$ /Users/jed/Downloads/280019/run-webkit-archive ; exit;
Setting DYLD FRAMEWORK and LIBRARY paths to /Users/jed/Downloads/280019/Release
dyld: Symbol not found: __ZN9Inspector17BackendDispatcher19reportProtocolErrorEN3WTF8OptionalIlEENS0_15CommonErrorCodeERKNS1_6StringE
  Referenced from: /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector
  Expected in: /Users/jed/Downloads/280019/Release/JavaScriptCore.framework/Versions/A/JavaScriptCore
 in /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector

I am running Safari 14.1.1 (16611.2.7.1.4) on macOS 11.4 (20F71), and Safari Technology Preview Release 127 (Safari 15.0, WebKit 16612.1.18.11.3). I use the fish shell, but running run-webkit-archive from bash produced the same error.

The symbol referenced above was also mentioned in Bug 165351, which was fixed at the end of 2016.

Comment 1 Smoley 2021-07-22 16:55:52 PDT

Thanks for filing, ccing relevant folks.

Comment 2 Radar WebKit Bug Importer 2021-07-22 16:56:05 PDT

<rdar://problem/80990972>

Comment 3 Patrick Angle 2021-09-08 20:05:31 PDT

Created attachment 437700 [details]
Patch v1.0

Comment 4 Alex Christensen 2021-09-08 22:30:26 PDT

Comment on attachment 437700 [details]
Patch v1.0

Sure.
If there are any symbols here that aren't needed, we should remove them.

Comment 5 Patrick Angle 2021-09-09 08:57:11 PDT

(In reply to Alex Christensen from comment #4)
> Comment on attachment 437700 [details]
> Patch v1.0
> 
> Sure.
> If there are any symbols here that aren't needed, we should remove them.

I believe for now we should keep the symbols added for pre-11.3 compatibility until a new version of Safari ships for Big Sur (or accept that the latest version of Big Sur is required for open source builds). I'll open bugs to remove the existing compatibility symbols as well as this new one so it is harder for us to forget to do so.

Comment 6 EWS 2021-09-09 10:02:36 PDT

Committed r282221 (241508@main): <https://commits.webkit.org/241508@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437700 [details].