Summary: | DFGByteCodeParser.cpp should avoid resizing the Operands<> of every BasicBlock on every inlining | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||||||||
Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||||||||
Status: | REOPENED --- | ||||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | 233387 | ||||||||||||
Bug Blocks: | |||||||||||||
Attachments: |
|
Description
Robin Morisset
2021-07-17 20:01:48 PDT
Created attachment 433740 [details]
Patch
Created attachment 433742 [details]
Patch
updated Changelog with perf numbers.
Created attachment 433743 [details]
Patch
Fix style nitpick.
Comment on attachment 433743 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433743&action=review r=me > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:8971 > + block->variablesAtHead = Operands<Node*>(m_numArguments, m_numLocals, m_numTmps); > + block->valuesAtHead = Operands<AbstractValue>(m_numArguments, m_numLocals, m_numTmps); > + block->valuesAtTail = Operands<AbstractValue>(m_numArguments, m_numLocals, m_numTmps); > + block->intersectionOfPastValuesAtHead = Operands<AbstractValue>(m_numArguments, m_numLocals, m_numTmps); nit: Use the OperandsLike constructor so these lines of code don't have to change in the future if we change the Operands constructor you're invoking? Created attachment 444624 [details]
Patch
Applied Saam's suggestion and rebased
Committed r286030 (244418@main): <https://commits.webkit.org/244418@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444624 [details]. Re-opened since this is blocked by bug 233387 |