Bug 228050

Summary: [LFC][IFC] LineBox provides redundant geometry information
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, sam, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2021-07-17 09:16:56 PDT
LineBoxGeometry is where we need this information
Attachments
Patch (14.49 KB, patch)
2021-07-17 09:35 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.84 KB, patch)
2021-07-17 11:24 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (14.36 KB, patch)
2021-08-19 17:01 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (24.25 KB, patch)
2021-08-19 20:13 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (24.34 KB, patch)
2021-08-20 08:49 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-07-17 09:35:21 PDT
Created attachment 433732 [details] Patch
alan
Comment 2 2021-07-17 11:24:29 PDT
Created attachment 433733 [details] Patch
Sam Weinig
Comment 3 2021-07-18 12:35:11 PDT
Comment on attachment 433733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433733&action=review > Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:359 > + m_logicalHeight = { }; extra space.
Radar WebKit Bug Importer
Comment 4 2021-07-24 09:17:15 PDT
<rdar://problem/81057163>
alan
Comment 5 2021-08-19 17:01:06 PDT
Created attachment 435924 [details] Patch
alan
Comment 6 2021-08-19 20:13:16 PDT
Created attachment 435935 [details] Patch
alan
Comment 7 2021-08-20 08:49:32 PDT
Created attachment 435993 [details] Patch
EWS
Comment 8 2021-08-20 13:50:50 PDT
Committed r281335 (240752@main): <https://commits.webkit.org/240752@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435993 [details].
Note You need to log in before you can comment on or make changes to this bug.