Bug 22805

Summary:

Implement image/URL dragging for Windows Cairo backend

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Patch implementing Windows Cairo image drag.	none
Use GraphicContext types, rather than CG-specific calls.	oliver: review+

Brent Fulgham

Reported 2008-12-10 23:14:21 PST

The DragImageCairoWin.cpp was basically a stub that didn't do anything. The attached patch provides an implementation of the corresponding CG code in terms of the Cairo API. This allows URL drag images to appear, as well as enabling the dragging of images.

Attachments
Patch implementing Windows Cairo image drag. (8.70 KB, patch) 2008-12-10 23:33 PST, Brent Fulgham	no flags	Details Formatted Diff Diff
Use GraphicContext types, rather than CG-specific calls. (9.46 KB, patch) 2008-12-11 22:15 PST, Brent Fulgham	oliver: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brent Fulgham

Comment 1 2008-12-10 23:33:58 PST

Created attachment 25942 [details] Patch implementing Windows Cairo image drag.

Oliver Hunt

Comment 2 2008-12-10 23:41:43 PST

Comment on attachment 25942 [details] Patch implementing Windows Cairo image drag. Do we have a typedef that encapsulates CGContextRef and struct _cairo* ? If we do we can remove the icky ifdefs in WebDragClient.cpp, but i think it would be much better if we could get this code to work in terms of GraphicsContext

Brent Fulgham

Comment 3 2008-12-11 10:29:06 PST

(In reply to comment #2) > (From update of attachment 25942 [details] [review]) > Do we have a typedef that encapsulates CGContextRef and struct _cairo* ? > > If we do we can remove the icky ifdefs in WebDragClient.cpp, but i think it > would be much better if we could get this code to work in terms of > GraphicsContext There are large regions of WebKit/win that are coded in terms of CoreGraphics primitives, that are just as applicable to the Cairo back-end. I would *love* to revise these to use GraphicsContext instead -- but will that be acceptable to the Apple side of things? This is maybe a question for Darin...

Brent Fulgham

Comment 4 2008-12-11 22:15:16 PST

Created attachment 25974 [details] Use GraphicContext types, rather than CG-specific calls.

Oliver Hunt

Comment 5 2008-12-11 22:22:52 PST

Comment on attachment 25974 [details] Use GraphicContext types, rather than CG-specific calls. r=me

Matt Lilek

Comment 6 2008-12-12 22:32:46 PST

Committed revision 39270.

Note You need to log in before you can comment on or make changes to this bug.