Summary: | Implement image/URL dragging for Windows Cairo backend | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
Brent Fulgham
2008-12-10 23:14:21 PST
Created attachment 25942 [details]
Patch implementing Windows Cairo image drag.
Comment on attachment 25942 [details]
Patch implementing Windows Cairo image drag.
Do we have a typedef that encapsulates CGContextRef and struct _cairo* ?
If we do we can remove the icky ifdefs in WebDragClient.cpp, but i think it would be much better if we could get this code to work in terms of GraphicsContext
(In reply to comment #2) > (From update of attachment 25942 [details] [review]) > Do we have a typedef that encapsulates CGContextRef and struct _cairo* ? > > If we do we can remove the icky ifdefs in WebDragClient.cpp, but i think it > would be much better if we could get this code to work in terms of > GraphicsContext There are large regions of WebKit/win that are coded in terms of CoreGraphics primitives, that are just as applicable to the Cairo back-end. I would *love* to revise these to use GraphicsContext instead -- but will that be acceptable to the Apple side of things? This is maybe a question for Darin... Created attachment 25974 [details]
Use GraphicContext types, rather than CG-specific calls.
Comment on attachment 25974 [details]
Use GraphicContext types, rather than CG-specific calls.
r=me
Committed revision 39270. |