Bug 228044

Summary:

Network access prevention SPI should prevent preconnecting, and it should first allow injected bundle to change request

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, ews-watchlist, ggaren, japhet, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	thorton: review+

Description Alex Christensen 2021-07-16 17:12:31 PDT

Network access prevention SPI should prevent preconnecting, and it should first allow injected bundle to change request

Comment 1 Alex Christensen 2021-07-16 17:17:18 PDT

Created attachment 433717 [details]
Patch

Comment 2 Alex Christensen 2021-07-16 17:17:21 PDT

<rdar://problem/72995136>

Comment 3 Alex Christensen 2021-07-16 17:19:49 PDT

Created attachment 433718 [details]
Patch

Comment 4 Alex Christensen 2021-07-16 17:21:26 PDT

*** Bug 227992 has been marked as a duplicate of this bug. ***

Comment 5 Tim Horton 2021-07-16 17:45:43 PDT

Comment on attachment 433718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433718&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/SchemeChangingPlugIn.mm:2
> + * Copyright (C) 2018 Apple Inc. All rights reserved.

2021!

Comment 6 Tim Horton 2021-07-16 17:46:08 PDT

Does seem reasonable and non-harmful, but because it's loader code it would really be good to make Brady look too!

Comment 7 Alex Christensen 2021-07-16 18:00:32 PDT

http://trac.webkit.org/r280014

Comment 8 Geoffrey Garen 2021-07-19 10:28:07 PDT

Nice!