Bug 228039

Summary:

PCM: Add early return when unlinkable token is used and add more happy path Web Inspector logging

Product:

WebKit

Reporter:

John Wilander <wilander>

Component:

WebKit Misc.

Assignee:

John Wilander <wilander>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, katherine_cheney, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description John Wilander 2021-07-16 15:31:40 PDT

We should do an early return when an accepted unlinkable token transaction is happening. We should also add more Web Inspector logging to the happy path for better developer feedback.

Comment 1 Radar WebKit Bug Importer 2021-07-16 15:32:06 PDT

<rdar://problem/80705989>

Comment 2 John Wilander 2021-07-16 15:38:18 PDT

Created attachment 433711 [details]
Patch

Comment 3 Kate Cheney 2021-07-16 16:18:43 PDT

Comment on attachment 433711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433711&action=review

r=me

> Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp:100
> +            return;

Nice catch.

Comment 4 John Wilander 2021-07-16 16:46:07 PDT

Comment on attachment 433711 [details]
Patch

Thank you, Kate!

Comment 5 EWS 2021-07-16 16:53:31 PDT

Committed r280009 (239751@main): <https://commits.webkit.org/239751@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433711 [details].