Bug 227984

Summary: [css-grid] Images as grid items should use the overridingLogicalHeight when defined to compute the logical width
Product: WebKit Reporter: zsun
Component: CSSAssignee: zsun
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, jfernandez, kondapallykalyan, obrufau, pdr, rbuis, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zsun
Reported 2021-07-15 02:18:59 PDT
RenderReplaced as grid items should use the overridingLogicalHeight when defined to compute the logical width.
Attachments
Patch (12.32 KB, patch)
2021-07-15 02:41 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Patch (12.12 KB, patch)
2021-07-19 02:17 PDT, zsun 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zsun
Comment 1 2021-07-15 02:41:24 PDT
Created attachment 433570 [details] Patch
Javier Fernandez
Comment 2 2021-07-17 02:59:35 PDT
Comment on attachment 433570 [details] Patch r=me
EWS
Comment 3 2021-07-19 01:44:56 PDT
Tools/Scripts/svn-apply failed to apply attachment 433570 [details] to trunk. Please resolve the conflicts and upload a new patch.
zsun
Comment 4 2021-07-19 02:17:34 PDT
Created attachment 433778 [details] Patch
EWS
Comment 5 2021-07-19 07:25:45 PDT
Committed r280024 (239766@main): <https://commits.webkit.org/239766@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433778 [details].
Radar WebKit Bug Importer
Comment 6 2021-07-19 07:26:20 PDT
<rdar://problem/80782877>
zsun
Comment 7 2021-07-20 04:56:29 PDT
*** Bug 227583 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.