Bug 227979

Summary: The fast text codepath does not handle run initial advances
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: Hironori.Fujii, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 206208    
Attachments:
Description Flags
Patch
none
Patch
none
WIP
none
Patch
none
Patch
none
Patch none

Description Myles C. Maxfield 2021-07-14 23:14:51 PDT 
The fast text codepath does not handle run initial advances
Comment 1 Myles C. Maxfield 2021-07-14 23:15:22 PDT 
Created attachment 433562 [details]
Patch
Comment 2 Myles C. Maxfield 2021-07-14 23:15:43 PDT 
Comment on attachment 433562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433562&action=review

> Source/WebCore/platform/graphics/ComplexTextController.cpp:725
> +                // FIXME: The initial advance needs to be added to the visually previous glyph's advance, not the current glyph's advance.

This might actually be false 🤔
Comment 3 Myles C. Maxfield 2021-07-14 23:29:40 PDT 
Created attachment 433564 [details]
Patch
Comment 4 Myles C. Maxfield 2021-07-19 22:20:13 PDT 
Comment on attachment 433562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433562&action=review

>> Source/WebCore/platform/graphics/ComplexTextController.cpp:725
>> +                // FIXME: The initial advance needs to be added to the visually previous glyph's advance, not the current glyph's advance.
> 
> This might actually be false 🤔

It isn't false.
Comment 5 Myles C. Maxfield 2021-07-19 23:34:24 PDT 
Created attachment 433851 [details]
WIP
Comment 6 Radar WebKit Bug Importer 2021-07-21 23:15:17 PDT 
<rdar://problem/80942757>
Comment 7 Myles C. Maxfield 2021-07-25 16:58:42 PDT 
Created attachment 434184 [details]
Patch
Comment 8 Myles C. Maxfield 2021-07-25 17:08:37 PDT 
Created attachment 434185 [details]
Patch
Comment 9 Myles C. Maxfield 2021-07-25 18:49:23 PDT 
Created attachment 434188 [details]
Patch
Comment 10 EWS 2021-08-19 21:53:29 PDT 
Committed r281294 (240718@main): <https://commits.webkit.org/240718@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434188 [details].