Bug 227973 – REGRESSION: http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html is timing out on some bots

• Component: Plug-ins
• Status: RESOLVED FIXED

http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html

Is timing out on Big Sur wk1 arm64

History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2FframeNavigation%2Fxss-DENIED-plugin-navigation.html

I was able to reproduce the timeout on my local intel machine using run-webkit-tests http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html --iterations 500 --exit-after-n-crashes-or-timeouts 2 -1

Diff: 

--- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt
+++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk1/build/layout-test-results/http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-actual.txt
@@ -1,5 +1,5 @@
-CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate navigation for frame with URL 'http://127.0.0.1:8000/security/resources/cross-frame-iframe.html' from frame with URL 'http://localhost:8000/security/frameNavigation/resources/frame-with-plugin-to-navigate.html'. The frame attempting navigation is neither same-origin with the target, nor is it the target's parent or opener.
-
+CONSOLE MESSAGE: TypeError: plg.getURL is not a function. (In 'plg.getURL("navigation-happened.html", "toNavigate")', 'plg.getURL' is undefined)
+FAIL: Timed out waiting for notifyDone to be called
 
 
 --------
@@ -10,7 +10,6 @@
 
 localhost
 
-Test PASSED
 
 
 --------

[Radar WebKit Bug Importer]

<rdar://problem/80604020>

I was able to reproduce the timeout on both intel and arm64 at r278029 but was not able to reproduce at r278010. There are no spades available to test between r278029 and r278010.

Created attachment 433591 [details]
Patch

Created attachment 433593 [details]
Update TestExpectations

[Truitt Savell]

Comment on attachment 433593 [details]
Update TestExpectations

Clearing flags on attachment: 433593

Committed r279952 (239695@main): <https://commits.webkit.org/239695@main>

[Alexey Proskuryakov]

The history of this test is super weird. It times out either consistently or flakily on various bots, and I don't see what determines that (looking at internal bots makes it even more confusing). And it starts at different points in time, but not with an OS upgrade.

More complete history: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2FframeNavigation%2Fxss-DENIED-plugin-navigation.html&limit=10000&recent=False

[Alexey Proskuryakov]

I was wondering if this was a bot to bot difference, but no - on the flaky queue, we get different results form the same tester bot, even for builds produced by the same builder.

This seems fixed. Removing the expectations: https://trac.webkit.org/changeset/282423/webkit