Summary: | [BMalloc] Lazily allocate physical pages | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | bmalloc | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren, mark.lam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | Other | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Michael Saboff
2021-07-14 10:09:15 PDT
Created attachment 433509 [details]
Patch
This patch provides a 3.5% (AS) to 4.6% (x86) reduction in memory in RAMification in my tests.
When testing JetStream2 and Speedometer2, it didn't regress on AS and is a 1.2% progression on both benchmarks for x86.
Comment on attachment 433509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433509&action=review r=me > Source/bmalloc/bmalloc/VMAllocate.h:-218 > - SYSCALL(madvise(p, vmSize, MADV_FREE_REUSE)); nit: Can you put the comment blurb from your ChangeLog in here about DARWIN not needing this madvise? Otherwise, I can see someone not-in-the-know naively re-adding this back in the future with no visible immediate fallout to provide feedback that it should not be done. (In reply to Mark Lam from comment #3) > Comment on attachment 433509 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=433509&action=review > > r=me > > > Source/bmalloc/bmalloc/VMAllocate.h:-218 > > - SYSCALL(madvise(p, vmSize, MADV_FREE_REUSE)); > > nit: Can you put the comment blurb from your ChangeLog in here about DARWIN > not needing this madvise? Otherwise, I can see someone not-in-the-know > naively re-adding this back in the future with no visible immediate fallout > to provide feedback that it should not be done. Sure. Comment on attachment 433509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433509&action=review > Source/bmalloc/bmalloc/VMAllocate.h:220 > + vmValidatePhysical(p, vmSize); Seems unnecessary to lose this assertion on Darwin. Comment on attachment 433509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433509&action=review >> Source/bmalloc/bmalloc/VMAllocate.h:220 >> + vmValidatePhysical(p, vmSize); > > Seems unnecessary to lose this assertion on Darwin. I'll add it back. Committed r279922 (239669@main): <https://commits.webkit.org/239669@main> |