Summary: | Implement Array.prototype.findLast and Array.prototype.findLastIndex | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | JavaScriptCore | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ews-watchlist, hi, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Devin Rousso
2021-07-13 20:05:28 PDT
Created attachment 433476 [details]
[Patch] WIP
Comment on attachment 433476 [details] [Patch] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=433476&action=review r=me > Source/JavaScriptCore/builtins/ArrayPrototype.js:269 > + var kValue = array[i]; I like the name like `element` instead of `kValue` even though it is derived from the spec's name since the name is not suitable for WebKit's coding style. Comment on attachment 433476 [details]
[Patch] WIP
Can you add tests in JSTests/stress?
Created attachment 433521 [details]
Patch
Created attachment 433528 [details]
Patch
Created attachment 433547 [details]
Patch
Committed r279937 (239681@main): <https://commits.webkit.org/239681@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433547 [details]. |