Bug 227935

Summary:

Add step name and description to InstallBuiltProduct build step

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

clopez, jbedard, mcatanzaro, pnormand, ryanhaddad, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=227526

Attachments:

Description	Flags
Patch	none

Description Aakash Jain 2021-07-13 18:14:40 PDT

https://trac.webkit.org/r279563 added InstallBuiltProduct build step. However, it didn't have step name and description. So the step shows up as 'shell' and 'python3 Tools/Scripts/install-built-product...' in the buildbot UI, e.g.: see step 11 in https://build.webkit.org/#/builders/41/builds/4247

We should add a proper name and description to this build step.

Comment 1 Aakash Jain 2021-07-13 18:22:25 PDT

Created attachment 433468 [details]
Patch

Comment 2 Philippe Normand 2021-07-14 00:37:22 PDT

Thanks Aakash!

Comment 3 EWS 2021-07-14 04:55:27 PDT

Committed r279908 (239657@main): <https://commits.webkit.org/239657@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433468 [details].

Comment 4 Radar WebKit Bug Importer 2021-07-14 04:56:16 PDT

<rdar://problem/80571466>

Comment 5 Aakash Jain 2021-07-14 05:22:07 PDT

Restarted buildbot on EWS to pick up this change. Seems to be working fine, e.g.: step 16 in https://ews-build.webkit.org/#/builders/36/builds/40064

(still need to restart build.webkit.org, it will be picked up in next buildbot restart)

Comment 6 Aakash Jain 2021-07-19 16:03:23 PDT

build.webkit.org was restarted few hours back and picked up this change. Seems to be working fine, e.g.: step 11 in https://build.webkit.org/#/builders/41/builds/4368