Bug 227934

Summary: [GStreamer] test media/media-source/media-webm-vorbis-partial.html fails
Product: WebKit Reporter: Arcady Goldmints-Orlov <crzwdjk>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: REOPENED    
Severity: Normal CC: aboya, philn, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Arcady Goldmints-Orlov
Reported 2021-07-13 17:46:10 PDT
These tests have been failing since they were added. Example below: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-source/media-webm-opus-partial-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/media/media-source/media-webm-opus-partial-actual.txt @@ -11,12 +11,12 @@ RUN(sourceBuffer.appendBuffer(partial1)) EVENT(update) EXPECTED (sourceBuffer.buffered.length == '1') OK -EXPECTED (sourceBuffer.buffered.end(0) == '3.621') OK +EXPECTED (sourceBuffer.buffered.end(0) == '3.621'), OBSERVED '3.6145' FAIL Complete the partial media segment. RUN(sourceBuffer.appendBuffer(partial2)) EVENT(update) EXPECTED (sourceBuffer.buffered.length == '1') OK -EXPECTED (sourceBuffer.buffered.end(0) == '10.001') OK +EXPECTED (sourceBuffer.buffered.end(0) == '10.001'), OBSERVED '9.9945' FAIL Clean sourcebuffer of all content. RUN(sourceBuffer.remove(0, 100)) EVENT(update) @@ -24,11 +24,11 @@ RUN(sourceBuffer.appendBuffer(loader.mediaSegment(1))) EVENT(update) EXPECTED (sourceBuffer.buffered.length == '1') OK -EXPECTED (sourceBuffer.buffered.end(0) == '90.001') OK +EXPECTED (sourceBuffer.buffered.end(0) == '90.001'), OBSERVED '89.9945' FAIL RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0))) EVENT(update) EXPECTED (sourceBuffer.buffered.length == '2') OK -EXPECTED (sourceBuffer.buffered.end(0) == '10.001') OK -EXPECTED (sourceBuffer.buffered.end(1) == '90.001') OK +EXPECTED (sourceBuffer.buffered.end(0) == '10.001'), OBSERVED '9.9945' FAIL +EXPECTED (sourceBuffer.buffered.end(1) == '90.001'), OBSERVED '89.9945' FAIL END OF TEST
Attachments
Patch (1.58 KB, patch)
2021-07-13 17:50 PDT, Arcady Goldmints-Orlov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Arcady Goldmints-Orlov
Comment 1 2021-07-13 17:50:36 PDT
Created attachment 433466 [details] Patch
Arcady Goldmints-Orlov
Comment 2 2021-07-13 17:51:37 PDT
Attached patch is for gardening the test failures. Not sure if it's a test issue, they are also apparently failing on mac.
EWS
Comment 3 2021-07-14 03:54:08 PDT
Committed r279907 (239656@main): <https://commits.webkit.org/239656@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433466 [details].
Radar WebKit Bug Importer
Comment 4 2021-07-14 03:55:17 PDT
<rdar://problem/80569141>
Philippe Normand
Comment 5 2021-07-14 04:29:14 PDT
Gardened. Patch might still be needed.
Alicia Boya García
Comment 6 2023-03-27 06:50:00 PDT
media/media-source/media-webm-opus-partial.html is passing after LayoutTests/media/media-source/content/test-opus.webm was modified by 260822@main
Philippe Normand
Comment 7 2024-01-22 01:28:51 PST
Only one issue left with media/media-source/media-webm-vorbis-partial.html: EXPECTED (sourceBuffer.buffered.end(0).toFixed(2) == '1.34'), OBSERVED '1.33' FAIL
Note You need to log in before you can comment on or make changes to this bug.