Bug 22793

Summary: Clean up FloatPoint3D
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: SVGAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Patch, changelog sam: review+

Simon Fraser (smfr)
Reported 2008-12-10 11:31:09 PST
Want to do some cleanup of FloatPoint3D.
Attachments
Patch, changelog (2.80 KB, patch)
2008-12-10 11:40 PST, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2008-12-10 11:40:13 PST
Created attachment 25922 [details] Patch, changelog
Sam Weinig
Comment 2 2008-12-10 11:56:12 PST
Comment on attachment 25922 [details] Patch, changelog > +FloatPoint3D::FloatPoint3D(const FloatPoint& p) > + : m_x(p.x()) > + , m_y(p.y()) > + , m_z(0.f) This should be m_z(0.0f) or just 0. > > +#include "FloatPoint.h" Can this simply be forward declared? Otherwise, r=me.
Simon Fraser (smfr)
Comment 3 2008-12-10 12:03:55 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/FloatPoint3D.cpp M WebCore/platform/graphics/FloatPoint3D.h Committed r39181
Note You need to log in before you can comment on or make changes to this bug.