Bug 227892

Summary: Web Inspector: REGRESSION(r279510): Elements: Computed: an (i) button is shown for computed property traces
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Patrick Angle <pangle>
Status: RESOLVED FIXED    
Severity: Normal CC: harshil.sratnu, hi, inspector-bugzilla-changes, nvasilyev, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 226883    
Bug Blocks:    
Attachments:
Description Flags
[Image] screen shot of issue
none
Patch v1.0
none
Patch v1.1 none

Devin Rousso
Reported 2021-07-12 17:13:37 PDT
Created attachment 433376 [details] [Image] screen shot of issue see attached screen shot reproduces on any page with any computed property trace
Attachments
[Image] screen shot of issue (74.38 KB, image/png)
2021-07-12 17:13 PDT, Devin Rousso 		no flags
Details
Patch v1.0 (1.72 KB, patch)
2021-07-12 17:26 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Patch v1.1 (1.72 KB, patch)
2021-07-12 17:50 PDT, Patrick Angle 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-12 17:15:03 PDT
<rdar://problem/80490487>
Patrick Angle
Comment 2 2021-07-12 17:26:52 PDT
Created attachment 433379 [details] Patch v1.0
Devin Rousso
Comment 3 2021-07-12 17:42:10 PDT
Comment on attachment 433379 [details] Patch v1.0 View in context: https://bugs.webkit.org/attachment.cgi?id=433379&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.css:154 > +.computed-style-section .property-trace-item .property .contextual-documentation-button { Can we do an `:is(.name, .colon, .semicolon, .contextual-documentation-button)` instead?
Patrick Angle
Comment 4 2021-07-12 17:50:24 PDT
Created attachment 433382 [details] Patch v1.1
EWS
Comment 5 2021-07-12 18:57:31 PDT
Committed r279862 (239615@main): <https://commits.webkit.org/239615@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433382 [details].
Note You need to log in before you can comment on or make changes to this bug.