Bug 227889

Summary: [build.webkit.org] Upload layout-tests results immediately after running layout-tests
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, clopez, jbedard, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Aakash Jain
Reported 2021-07-12 16:25:48 PDT
Currently on build.webkit.org builds, we run layout-tests, then we run various other test suites (e.g.: api, webkitpy, webkitperl, etc.), then we upload the layout-test results and make them accessible to the user. After finishing the layout-tests, there can be a delay of upto an hour before results are uploaded and made available to the user, e.g.: see step 11 and 21 in https://build.webkit.org/#/builders/59/builds/1972. We should upload the layout test results immediately after completing layout-tests.
Attachments
Patch (1.88 KB, patch)
2021-07-12 16:27 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (2.15 KB, patch)
2021-07-12 16:30 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Patch (2.50 KB, patch)
2021-07-13 05:44 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2021-07-12 16:27:42 PDT
Created attachment 433369 [details] Patch
Aakash Jain
Comment 2 2021-07-12 16:30:36 PDT
Created attachment 433370 [details] Patch
Carlos Alberto Lopez Perez
Comment 3 2021-07-12 16:45:06 PDT
Comment on attachment 433370 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433370&action=review > Tools/CISupport/build-webkit-org/factories.py:103 > self.addStep(self.LayoutTestClass()) > + self.addStep(ArchiveTestResults()) > + self.addStep(UploadTestResults()) > + self.addStep(ExtractTestResults()) > + self.addStep(SetPermissions()) Maybe RunDashboardTests() should run before ExtractTestResults() ? so the "view dashboard test results" links that appears when you click on the arrow on the step of "extract-test-results" works? Not sure if its really needed that it runs before.
Aakash Jain
Comment 4 2021-07-12 16:56:00 PDT
(In reply to Carlos Alberto Lopez Perez from comment #3) > Maybe RunDashboardTests() should run before ExtractTestResults() ? so the "view dashboard test results" links that appears when you click on the arrow on the step of "extract-test-results" works? Good point, will do that.
Aakash Jain
Comment 5 2021-07-13 05:44:33 PDT
Created attachment 433402 [details] Patch
Aakash Jain
Comment 6 2021-07-13 05:45:44 PDT
Sample run: https://build.webkit-dev.org/#/builders/82/builds/8
EWS
Comment 7 2021-07-13 09:46:25 PDT
Committed r279875 (239628@main): <https://commits.webkit.org/239628@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433402 [details].
Radar WebKit Bug Importer
Comment 8 2021-07-13 09:47:16 PDT
<rdar://problem/80523498>
Aakash Jain
Comment 9 2021-07-19 16:16:53 PDT
build.webkit.org was restarted to pick up this change. Seems to be working fine, e.g.: https://build.webkit.org/#/builders/48/builds/4133
Note You need to log in before you can comment on or make changes to this bug.