[build.webkit.org] Upload layout-tests results immediately after running layout-tests

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Aakash Jain]

Currently on build.webkit.org builds, we run layout-tests, then we run various other test suites (e.g.: api, webkitpy, webkitperl,  etc.), then we upload the layout-test results and make them accessible to the user. After finishing the layout-tests, there can be a delay of upto an hour before results are uploaded and made available to the user, e.g.: see step 11 and 21 in https://build.webkit.org/#/builders/59/builds/1972. We should upload the layout test results immediately after completing layout-tests.

[Aakash Jain]

Created attachment 433369 [details]
Patch

[Aakash Jain]

Created attachment 433370 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 433370 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433370&action=review

> Tools/CISupport/build-webkit-org/factories.py:103
>              self.addStep(self.LayoutTestClass())
> +            self.addStep(ArchiveTestResults())
> +            self.addStep(UploadTestResults())
> +            self.addStep(ExtractTestResults())
> +            self.addStep(SetPermissions())

Maybe RunDashboardTests() should run before ExtractTestResults() ? so the "view dashboard test results" links that appears when you click on the arrow on the step of "extract-test-results" works?

Not sure if its really needed that it runs before.

[Aakash Jain]

(In reply to Carlos Alberto Lopez Perez from comment #3)
> Maybe RunDashboardTests() should run before ExtractTestResults() ? so the "view dashboard test results" links that appears when you click on the arrow on the step of "extract-test-results" works?
Good point, will do that.

[Aakash Jain]

Created attachment 433402 [details]
Patch

[Aakash Jain]

Sample run: https://build.webkit-dev.org/#/builders/82/builds/8

[EWS]

Committed r279875 (239628@main): <https://commits.webkit.org/239628@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433402 [details].

[Radar WebKit Bug Importer]

<rdar://problem/80523498>

[Aakash Jain]

build.webkit.org was restarted to pick up this change. Seems to be working fine, e.g.: https://build.webkit.org/#/builders/48/builds/4133