Bug 227871

Summary: [iOS] Dynamically set capture attribution
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=228596
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Build fix
none
Patch for landing none

Description Eric Carlson 2021-07-12 05:27:46 PDT 
Dynamically set capture attribution
Comment 1 Eric Carlson 2021-07-12 05:28:55 PDT 
rdar://70241665
Comment 2 Eric Carlson 2021-07-12 12:31:46 PDT 
Created attachment 433340 [details]
Patch
Comment 3 Eric Carlson 2021-07-12 12:48:43 PDT 
Created attachment 433342 [details]
Patch
Comment 4 Eric Carlson 2021-07-12 18:29:09 PDT 
Created attachment 433384 [details]
Patch
Comment 5 Eric Carlson 2021-07-13 05:55:37 PDT 
Created attachment 433404 [details]
Patch
Comment 6 Eric Carlson 2021-07-14 05:49:38 PDT 
The plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html layout test failure is unrelated.
Comment 7 EWS 2021-07-14 11:06:36 PDT 
Committed r279912 (239661@main): <https://commits.webkit.org/239661@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433404 [details].
Comment 8 Brent Fulgham 2021-07-14 11:13:24 PDT 
Comment on attachment 433404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433404&action=review

> Source/WebKit/Scripts/process-entitlements.sh:315
> +    plistbuddy Add :com.apple.security.exception.mach-lookup.global-name:0 string com.apple.systemstatus.activityattribution

I don't think you need this entitlement, since you are granting the same access in the com.apple.WebKit.GPU.sb file change.
Comment 9 Jer Noble 2021-07-14 14:45:19 PDT 
Reopening to attach new patch.
Comment 10 Jer Noble 2021-07-14 14:45:21 PDT 
Created attachment 433531 [details]
Build fix
Comment 11 EWS 2021-07-14 14:46:15 PDT 
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Comment 12 Jer Noble 2021-07-14 14:52:10 PDT 
Created attachment 433532 [details]
Patch for landing
Comment 13 EWS 2021-07-14 15:56:55 PDT 
Committed r279929 (239676@main): <https://commits.webkit.org/239676@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433532 [details].