Bug 227871

Summary: [iOS] Dynamically set capture attribution
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: WebRTCAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=228596
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Build fix
none
Patch for landing none

Eric Carlson
Reported 2021-07-12 05:27:46 PDT
Dynamically set capture attribution
Attachments
Patch (38.61 KB, patch)
2021-07-12 12:31 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (38.58 KB, patch)
2021-07-12 12:48 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (38.73 KB, patch)
2021-07-12 18:29 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Patch (38.10 KB, patch)
2021-07-13 05:55 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Build fix (4.62 KB, patch)
2021-07-14 14:45 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.54 KB, patch)
2021-07-14 14:52 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2021-07-12 05:28:55 PDT
rdar://70241665
Eric Carlson
Comment 2 2021-07-12 12:31:46 PDT
Created attachment 433340 [details] Patch
Eric Carlson
Comment 3 2021-07-12 12:48:43 PDT
Created attachment 433342 [details] Patch
Eric Carlson
Comment 4 2021-07-12 18:29:09 PDT
Created attachment 433384 [details] Patch
Eric Carlson
Comment 5 2021-07-13 05:55:37 PDT
Created attachment 433404 [details] Patch
Eric Carlson
Comment 6 2021-07-14 05:49:38 PDT
The plugins-types-blocks-quicktime-plugin-replacement-without-mime-type.html layout test failure is unrelated.
EWS
Comment 7 2021-07-14 11:06:36 PDT
Committed r279912 (239661@main): <https://commits.webkit.org/239661@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433404 [details].
Brent Fulgham
Comment 8 2021-07-14 11:13:24 PDT
Comment on attachment 433404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433404&action=review > Source/WebKit/Scripts/process-entitlements.sh:315 > + plistbuddy Add :com.apple.security.exception.mach-lookup.global-name:0 string com.apple.systemstatus.activityattribution I don't think you need this entitlement, since you are granting the same access in the com.apple.WebKit.GPU.sb file change.
Jer Noble
Comment 9 2021-07-14 14:45:19 PDT
Reopening to attach new patch.
Jer Noble
Comment 10 2021-07-14 14:45:21 PDT
Created attachment 433531 [details] Build fix
EWS
Comment 11 2021-07-14 14:46:15 PDT
ChangeLog entry in Source/WTF/ChangeLog contains OOPS!.
Jer Noble
Comment 12 2021-07-14 14:52:10 PDT
Created attachment 433532 [details] Patch for landing
EWS
Comment 13 2021-07-14 15:56:55 PDT
Committed r279929 (239676@main): <https://commits.webkit.org/239676@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433532 [details].
Note You need to log in before you can comment on or make changes to this bug.