Bug 227858

Summary: [Line layout] "zero width space" (U+200B) is a breaking space
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
koivisto: review+
Patch
none
Patch
none
Patch none

Description zalan 2021-07-10 21:13:05 PDT 
soft wrap opportunity
Comment 1 zalan 2021-07-10 21:15:12 PDT 
Created attachment 433284 [details]
Patch
Comment 2 zalan 2021-07-11 20:42:06 PDT 
Created attachment 433297 [details]
Patch
Comment 3 Antti Koivisto 2021-07-12 08:30:02 PDT 
Comment on attachment 433297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433297&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:57
> +    auto curentContent = nextInlineTextItem.inlineTextBox().content();

spelling 'current'
Comment 4 zalan 2021-07-12 08:34:34 PDT 
Created attachment 433320 [details]
Patch
Comment 5 Antti Koivisto 2021-07-12 08:35:13 PDT 
Comment on attachment 433297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433297&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:59
> +    if (curentContent.is8Bit() && !previousContent.is8Bit())
> +        curentContent = String::make16BitFrom8BitSource(curentContent.characters8(), curentContent.length());

Could use a comment.
Comment 6 Radar WebKit Bug Importer 2021-07-17 21:14:18 PDT 
<rdar://problem/80738042>
Comment 7 zalan 2021-08-19 14:10:38 PDT 
Created attachment 435902 [details]
Patch
Comment 8 zalan 2021-08-19 14:31:16 PDT 
Created attachment 435905 [details]
Patch
Comment 9 EWS 2021-08-19 15:23:38 PDT 
Committed r281272 (240697@main): <https://commits.webkit.org/240697@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435905 [details].