Bug 227858

Summary: [Line layout] "zero width space" (U+200B) is a breaking space
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
koivisto: review+
Patch
none
Patch
none
Patch none

alan
Reported 2021-07-10 21:13:05 PDT
soft wrap opportunity
Attachments
Patch (3.63 KB, patch)
2021-07-10 21:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2021-07-11 20:42 PDT, alan 		koivisto: review+
DetailsFormatted DiffDiff
Patch (2.11 KB, patch)
2021-07-12 08:34 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (2.30 KB, patch)
2021-08-19 14:10 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (2.40 KB, patch)
2021-08-19 14:31 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-07-10 21:15:12 PDT
Created attachment 433284 [details] Patch
alan
Comment 2 2021-07-11 20:42:06 PDT
Created attachment 433297 [details] Patch
Antti Koivisto
Comment 3 2021-07-12 08:30:02 PDT
Comment on attachment 433297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433297&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:57 > + auto curentContent = nextInlineTextItem.inlineTextBox().content(); spelling 'current'
alan
Comment 4 2021-07-12 08:34:34 PDT
Created attachment 433320 [details] Patch
Antti Koivisto
Comment 5 2021-07-12 08:35:13 PDT
Comment on attachment 433297 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433297&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:59 > + if (curentContent.is8Bit() && !previousContent.is8Bit()) > + curentContent = String::make16BitFrom8BitSource(curentContent.characters8(), curentContent.length()); Could use a comment.
Radar WebKit Bug Importer
Comment 6 2021-07-17 21:14:18 PDT
<rdar://problem/80738042>
alan
Comment 7 2021-08-19 14:10:38 PDT
Created attachment 435902 [details] Patch
alan
Comment 8 2021-08-19 14:31:16 PDT
Created attachment 435905 [details] Patch
EWS
Comment 9 2021-08-19 15:23:38 PDT
Committed r281272 (240697@main): <https://commits.webkit.org/240697@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435905 [details].
Note You need to log in before you can comment on or make changes to this bug.