| Summary: | [GTK] 2.33.2: cmake fails on detecting libsoup | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tomasz Kłoczko <kloczko.tomasz> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, pgriffis |
| Priority: | P3 | Keywords: | Gtk |
| Version: | WebKit Local Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
|
Description
Tomasz Kłoczko
2021-07-09 07:50:37 PDT
You either need libsoup3 (highly recommended, it enables HTTP/2) or else -DUSE_SOUP2=ON for the fallback behavior. (In reply to Tomasz Kłoczko from comment #0) > CMake Warning at Source/cmake/WebKitFeatures.cmake:90 (message): > Building with USE_64KB_PAGE_BLOCK on an architecture other than aarch64 is > unusual. Are you sure you want USE_64KB_PAGE_BLOCK? > Call Stack (most recent call first): > Source/cmake/OptionsGTK.cmake:4 (WEBKIT_OPTION_BEGIN) > Source/cmake/WebKitCommon.cmake:216 (include) > CMakeLists.txt:20 (include) This disables JIT, so it's going to result in terrible performance, and also bmalloc, including all our heap security features. You almost certainly don't want this.... (In reply to Michael Catanzaro from comment #1) > You either need libsoup3 (highly recommended, it enables HTTP/2) or else > -DUSE_SOUP2=ON for the fallback behavior. And that is the problem that webkitgtk cmake instead checking first libsoup-2.4 and if not found libsoup-3.0 (or in reverse order) is forring tiu use -DUSE_SOUP2=ON. At the moment all projects which uses webkitgtk are still uisng gtk 3.x so linking with gtk 3.x and gtk 4.0 (use libsoup-3.0 seems requires gtk 4.x) does not make any sense and probably will cause symbol clkash. (In reply to Michael Catanzaro from comment #1) > You either need libsoup3 (highly recommended, it enables HTTP/2) or else > -DUSE_SOUP2=ON for the fallback behavior. And that is the problem that webkitgtk cmake instead checking first libsoup-2.4 and if not found libsoup-3.0 (or in reverse order) is forring tiu use -DUSE_SOUP2=ON. At the moment all projects which uses webkitgtk are still uisng gtk 3.x so linking with gtk 3.x and gtk 4.0 (use libsoup-3.0 seems requires gtk 4.x) does not make any sense and probably will cause symbol clkash. Just to clarify, libsoup has nothing to do with GTK3 or GTK4. OK my mistake. (In reply to Tomasz Kłoczko from comment #4) > And that is the problem that webkitgtk cmake instead checking first > libsoup-2.4 and if not found libsoup-3.0 (or in reverse order) is forring > tiu use -DUSE_SOUP2=ON. We want the build to fail unless you manually pass -DUSE_SOUP2=ON, since that is a fallback option. It should not be possible to silently miss that libsoup3 is now expected, so automatically falling back to libsoup2 is not desired. The error message could be better, though.... |