Bug 227832

Summary: [JSC] Intl.DisplayNames v2
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=229608
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
ross.kirsling: review+
Patch none

Yusuke Suzuki
Reported 2021-07-09 01:37:43 PDT
...
Attachments
Patch (23.59 KB, patch)
2021-07-10 18:46 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (26.36 KB, patch)
2021-07-11 00:50 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (29.52 KB, patch)
2021-08-07 03:20 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (33.89 KB, patch)
2021-08-20 01:25 PDT, Yusuke Suzuki 		ross.kirsling: review+
DetailsFormatted DiffDiff
Patch (35.45 KB, patch)
2021-08-21 08:21 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-07-10 17:09:57 PDT
https://github.com/tc39/intl-displaynames-v2
Yusuke Suzuki
Comment 2 2021-07-10 18:46:58 PDT
Created attachment 433283 [details] Patch
Yusuke Suzuki
Comment 3 2021-07-11 00:50:40 PDT
Created attachment 433286 [details] Patch
Radar WebKit Bug Importer
Comment 4 2021-07-16 01:38:15 PDT
<rdar://problem/80674704>
Yusuke Suzuki
Comment 5 2021-08-07 03:20:35 PDT
Created attachment 435125 [details] Patch
Yusuke Suzuki
Comment 6 2021-08-20 01:25:34 PDT
Created attachment 435951 [details] Patch
Ross Kirsling
Comment 7 2021-08-20 15:43:36 PDT
Comment on attachment 435951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435951&action=review r=me with comments > Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:210 > + // If code does not matches the unicode_language_id production, throw a RangeError exception > + if (!isUnicodeLanguageId(code)) { > + throwRangeError(globalObject, scope, "argument is not a language id"_s); Hmm, I feel like this comment doesn't add any information. (Ditto for the region and script ones.) > Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:295 > + // Convert code to legacy names since ICU requires legacy names. Ooh, this could use the helper function I suggested in the Locale Info patch too.
Yusuke Suzuki
Comment 8 2021-08-21 08:08:44 PDT
Comment on attachment 435951 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435951&action=review >> Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:210 >> + throwRangeError(globalObject, scope, "argument is not a language id"_s); > > Hmm, I feel like this comment doesn't add any information. (Ditto for the region and script ones.) Removed. >> Source/JavaScriptCore/runtime/IntlDisplayNames.cpp:295 >> + // Convert code to legacy names since ICU requires legacy names. > > Ooh, this could use the helper function I suggested in the Locale Info patch too. Changed.
Yusuke Suzuki
Comment 9 2021-08-21 08:21:21 PDT
Created attachment 436073 [details] Patch
EWS
Comment 10 2021-08-21 09:17:08 PDT
Committed r281375 (240790@main): <https://commits.webkit.org/240790@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436073 [details].
Note You need to log in before you can comment on or make changes to this bug.