Bug 227825

Summary: Allow layout tests to specify app initiated loads or not
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: WebKit Misc.Assignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ddkilzer, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Description Kate Cheney 2021-07-08 19:39:45 PDT 
We should expand App Privacy Report layout testing
Comment 1 Radar WebKit Bug Importer 2021-07-08 19:40:15 PDT 
<rdar://problem/80355582>
Comment 2 Kate Cheney 2021-07-08 20:20:01 PDT 
Created attachment 433194 [details]
Patch
Comment 3 Kate Cheney 2021-07-09 10:32:17 PDT 
Created attachment 433223 [details]
Patch
Comment 4 Kate Cheney 2021-07-09 15:00:00 PDT 
Created attachment 433241 [details]
Patch
Comment 5 Kate Cheney 2021-07-12 13:38:53 PDT 
Created attachment 433350 [details]
Patch
Comment 6 Kate Cheney 2021-07-12 13:52:54 PDT 
Created attachment 433353 [details]
Patch
Comment 7 Brent Fulgham 2021-07-12 21:56:29 PDT 
Comment on attachment 433353 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433353&action=review

R=me, but consider using a HAVE macro, perhaps in a follow up patch, to gate this on the presence of app initiation state in a build, rather than OS family,

> Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:99
> +#if PLATFORM(IOS_FAMILY)

This might be better as a HAVE macro (e.g., HAVE(APP_ATTRIBUTION) or something).
Comment 8 Kate Cheney 2021-07-13 08:20:32 PDT 
Thanks!

(In reply to Brent Fulgham from comment #7)
> Comment on attachment 433353 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=433353&action=review
> 
> R=me, but consider using a HAVE macro, perhaps in a follow up patch, to gate
> this on the presence of app initiation state in a build, rather than OS
> family,

Good point, and one even exists, ENABLE(APP_PRIVACY_REPORT), that I forgot to use. Will fix before landing.

> 
> > Source/WebKit/UIProcess/API/APIPageConfiguration.cpp:99
> > +#if PLATFORM(IOS_FAMILY)
> 
> This might be better as a HAVE macro (e.g., HAVE(APP_ATTRIBUTION) or
> something).
Comment 9 Kate Cheney 2021-07-13 08:34:06 PDT 
Created attachment 433405 [details]
Patch for landing
Comment 10 EWS 2021-07-13 09:40:19 PDT 
Committed r279874 (239627@main): <https://commits.webkit.org/239627@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433405 [details].