Bug 227813

Summary: [IndexedDB] KeyPath validity checks should happen on the cloned value, not the original one
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, alecflett, beidson, darin, ews-watchlist, ggaren, jsbell, sam, sihui_liu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2021-07-08 14:08:46 PDT
KeyPath validity checks should happen on the cloned value, not the original one: - https://www.w3.org/TR/IndexedDB/#add-or-put (Step 11.1) - https://www.w3.org/TR/IndexedDB/#dom-idbcursor-update (Step 9.1) This is causing the following WPT test to fail in WebKit: https://wpt.live/IndexedDB/clone-before-keypath-eval.html This test is passing in Chrome and Gecko.
Attachments
Patch (13.35 KB, patch)
2021-07-08 14:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-07-08 14:11:46 PDT
Created attachment 433162 [details] Patch
Geoffrey Garen
Comment 2 2021-07-08 16:33:13 PDT
Comment on attachment 433162 [details] Patch r=me
EWS
Comment 3 2021-07-08 17:11:29 PDT
Committed r279767 (239537@main): <https://commits.webkit.org/239537@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433162 [details].
Radar WebKit Bug Importer
Comment 4 2021-07-08 17:12:17 PDT
<rdar://problem/80350450>
Note You need to log in before you can comment on or make changes to this bug.