Summary: | RenderLayerScrollableArea::updateScrollPosition assumes that it can scroll to the targeted scroll position | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | Scrolling | Assignee: | Martin Robinson <mrobinson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Martin Robinson
2021-07-08 10:32:07 PDT
Created attachment 433138 [details]
Patch
Created attachment 433303 [details]
Patch
Looks like my original change did not take into account the in-progress smooth scrolling API. I've modified this patch so that instead of using `scrollOffset()` to adjust the output rectangle, `scrollToOffset()` now returns the snapped scroll offset. Committed r279869 (239622@main): <https://commits.webkit.org/239622@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433303 [details]. |