Bug 227803

Summary: RenderLayerScrollableArea::updateScrollPosition assumes that it can scroll to the targeted scroll position
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: ScrollingAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Martin Robinson
Reported 2021-07-08 10:32:07 PDT
RenderLayerScrollableArea::updateScrollPosition calculates a target scroll offset and tries to scroll there before returning an adjusted rectangle. The adjusted rectangle is based on the target scroll offset, rather than the area's true new scroll offset. The target offset may not be equal to the area's true offset due to scroll snapping.
Attachments
Patch (4.16 KB, patch)
2021-07-08 10:35 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (6.53 KB, patch)
2021-07-12 01:52 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-07-08 10:35:13 PDT
Created attachment 433138 [details] Patch
Martin Robinson
Comment 2 2021-07-12 01:52:46 PDT
Created attachment 433303 [details] Patch
Martin Robinson
Comment 3 2021-07-12 08:29:53 PDT
Looks like my original change did not take into account the in-progress smooth scrolling API. I've modified this patch so that instead of using `scrollOffset()` to adjust the output rectangle, `scrollToOffset()` now returns the snapped scroll offset.
EWS
Comment 4 2021-07-13 01:17:36 PDT
Committed r279869 (239622@main): <https://commits.webkit.org/239622@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433303 [details].
Radar WebKit Bug Importer
Comment 5 2021-07-13 01:18:28 PDT
<rdar://problem/80505941>
Note You need to log in before you can comment on or make changes to this bug.