Bug 227751

Summary: [Legacy Line Layout] Do not integral round the root inlinebox's top position
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, koivisto, kondapallykalyan, mmaxfield, pdr, philipj, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

alan
Reported 2021-07-07 10:27:33 PDT
snapping should rather happen during painting
Attachments
Patch (1.74 MB, patch)
2021-09-09 14:27 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (1.74 MB, patch)
2021-09-09 20:59 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (1.74 MB, patch)
2021-09-10 09:47 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (1.75 MB, patch)
2021-09-10 15:07 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-07-14 10:28:27 PDT
<rdar://problem/80584346>
alan
Comment 2 2021-09-09 14:27:35 PDT
Created attachment 437785 [details] Patch
alan
Comment 3 2021-09-09 20:59:43 PDT
Created attachment 437833 [details] Patch
alan
Comment 4 2021-09-10 09:47:29 PDT
Created attachment 437883 [details] Patch
alan
Comment 5 2021-09-10 15:07:55 PDT
Created attachment 437912 [details] Patch
alan
Comment 6 2021-09-10 16:00:54 PDT
We push the coordinate values through a bunch of implicit and explicit integral conversions as we dump them (see webkit.org/b/230174). It's misleading as renderers may be at a slightly different position (e.g. vertical -1px values).
EWS
Comment 7 2021-09-10 21:24:30 PDT
Committed r282306 (241578@main): <https://commits.webkit.org/241578@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437912 [details].
Note You need to log in before you can comment on or make changes to this bug.