Bug 227742

Summary: Set Caption preferences in the UI process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 227937    
Attachments:
Description Flags
Patch
none
Patch
eric.carlson: review+
Patch none

Per Arne Vollan
Reported 2021-07-07 03:43:17 PDT
Due to sandbox restrictions in the WebContent process, Caption preferences should be set in the UI process.
Attachments
Patch (27.28 KB, patch)
2021-07-07 07:04 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (27.28 KB, patch)
2021-07-07 08:15 PDT, Per Arne Vollan 		eric.carlson: review+
DetailsFormatted DiffDiff
Patch (26.85 KB, patch)
2021-07-08 00:09 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-07-07 03:45:33 PDT
<rdar://79040526>
Per Arne Vollan
Comment 2 2021-07-07 07:04:53 PDT
Created attachment 433026 [details] Patch
Per Arne Vollan
Comment 3 2021-07-07 08:15:20 PDT
Created attachment 433029 [details] Patch
Eric Carlson
Comment 4 2021-07-07 08:35:44 PDT
Comment on attachment 433029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433029&action=review > Source/WebCore/WebCore.xcodeproj/project.pbxproj:5527 > - FD3160BF12B0272A00C1A359 /* AudioFileReaderMac.h in Headers */ = {isa = PBXBuildFile; fileRef = FD3160B912B0272A00C1A359 /* AudioFileReaderMac.h */; }; > + FD3160BF12B0272A00C1A359 /* (null) in Headers */ = {isa = PBXBuildFile; }; Nit: this seems unintentional > Source/WebCore/WebCore.xcodeproj/project.pbxproj:31619 > + FD3160BF12B0272A00C1A359 /* (null) in Headers */, Ditto
Per Arne Vollan
Comment 5 2021-07-07 10:53:17 PDT
(In reply to Eric Carlson from comment #4) > Comment on attachment 433029 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=433029&action=review > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:5527 > > - FD3160BF12B0272A00C1A359 /* AudioFileReaderMac.h in Headers */ = {isa = PBXBuildFile; fileRef = FD3160B912B0272A00C1A359 /* AudioFileReaderMac.h */; }; > > + FD3160BF12B0272A00C1A359 /* (null) in Headers */ = {isa = PBXBuildFile; }; > > Nit: this seems unintentional > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:31619 > > + FD3160BF12B0272A00C1A359 /* (null) in Headers */, > > Ditto Will fix. Thanks for reviewing!
Per Arne Vollan
Comment 6 2021-07-08 00:09:23 PDT
Created attachment 433123 [details] Patch
Per Arne Vollan
Comment 7 2021-07-08 04:38:32 PDT
(In reply to Per Arne Vollan from comment #5) > (In reply to Eric Carlson from comment #4) > > Comment on attachment 433029 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=433029&action=review > > > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:5527 > > > - FD3160BF12B0272A00C1A359 /* AudioFileReaderMac.h in Headers */ = {isa = PBXBuildFile; fileRef = FD3160B912B0272A00C1A359 /* AudioFileReaderMac.h */; }; > > > + FD3160BF12B0272A00C1A359 /* (null) in Headers */ = {isa = PBXBuildFile; }; > > > > Nit: this seems unintentional > > > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:31619 > > > + FD3160BF12B0272A00C1A359 /* (null) in Headers */, > > > > Ditto > > Will fix. > These files seem to have been removed earlier, and Xcode removed the references in the project file. > Thanks for reviewing!
EWS
Comment 8 2021-07-08 04:46:29 PDT
Committed r279720 (239508@main): <https://commits.webkit.org/239508@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433123 [details].
Note You need to log in before you can comment on or make changes to this bug.