Summary: | Only first set-cookie HTTP header in websocket http response is accepted | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Shu Muto <shu.mutow> | ||||||||
Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
Status: | REOPENED --- | ||||||||||
Severity: | Normal | CC: | aakash_jain, achristensen, ap, commit-queue, ggaren, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | Safari 14 | ||||||||||
Hardware: | iPhone / iPad | ||||||||||
OS: | iOS 14 | ||||||||||
Bug Depends on: | 227903 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Shu Muto
2021-07-06 23:44:43 PDT
Does this still reproduce in iOS 15 beta? Could you please provide a test page if this is still an issue? Created attachment 433084 [details]
Patch
Here's a test that verifies that this has been fixed in the latest version as well as in the pre-iOS15/Monterey WebSocket implementation. I haven't verified that it was ever broken, so if it was or still is some other way, please let us know. Comment on attachment 433084 [details]
Patch
r=me
Thanks for telling me that this issue has been fixed in iOS 15 and creating tests that ensure the fix! I don't have Mac, so I can not install beta version. Sorry. Committed r279705 (239497@main): <https://commits.webkit.org/239497@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433084 [details]. (In reply to EWS from comment #6) > Committed r279705 (239497@main): <https://commits.webkit.org/239497@main> Newly added test http/tests/websocket/tests/hybi/multiple-set-cookies.htm is consistently failing on windows. History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fmultiple-set-cookies.html Re-opened since this is blocked by bug 227903 Upon closer inspection, in pre-iOS 15 we get the cookies separated with a comma, but in iOS 15 we get the cookies separated with a semicolon, which matches Chrome and Firefox. Created attachment 433456 [details]
Patch
Created attachment 433507 [details]
Patch
|