Bug 227713

Summary: r270214 broke testb3 on arm64e
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219281
Attachments:
Description Flags
Patch
saam: review+, ews-feeder: commit-queue-
Patch
none
Patch none

Description Saam Barati 2021-07-06 10:54:39 PDT 
For example:

O0: testAtomicStrongCAS<int32_t>()...
ASSERTION FAILED: value[0] == static_cast<T>(100) (value[0] == 48879, static_cast<T>(100) == 100)
Comment 1 Saam Barati 2021-07-06 11:09:56 PDT 
weak cas test is also broken:

O0: testAtomicWeakCAS<int8_t>()...
ASSERTION FAILED: value[0] == static_cast<T>(100) (value[0] == -17, static_cast<T>(100) == 100)
/Users/saambarati/WK/a/OpenSource/Source/JavaScriptCore/b3/testb3_8.cpp(148) : void testAtomicWeakCAS() [T = signed char]
Comment 2 Yusuke Suzuki 2021-07-06 18:46:52 PDT 
Created attachment 432995 [details]
Patch
Comment 3 Saam Barati 2021-07-06 18:49:43 PDT 
Comment on attachment 432995 [details]
Patch

r=me, nice
Comment 4 Mark Lam 2021-07-06 18:50:49 PDT 
EWS errors look real.
Comment 5 Yusuke Suzuki 2021-07-06 18:53:14 PDT 
Created attachment 432996 [details]
Patch
Comment 6 Yusuke Suzuki 2021-07-06 20:28:11 PDT 
Created attachment 433002 [details]
Patch
Comment 7 Yusuke Suzuki 2021-07-07 11:45:04 PDT 
Committed r279653 (239466@main): <https://commits.webkit.org/239466@main>
Comment 8 Radar WebKit Bug Importer 2021-07-07 11:46:16 PDT 
<rdar://problem/80281537>