Bug 227713

Summary:

r270214 broke testb3 on arm64e

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

JavaScriptCore

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=219281

Attachments:

Description	Flags
Patch	saam: review+, ews-feeder: commit-queue-
Patch	none
Patch	none

Saam Barati

Reported 2021-07-06 10:54:39 PDT

For example: O0: testAtomicStrongCAS<int32_t>()... ASSERTION FAILED: value[0] == static_cast<T>(100) (value[0] == 48879, static_cast<T>(100) == 100)

Attachments
Patch (10.04 KB, patch) 2021-07-06 18:46 PDT, Yusuke Suzuki	saam: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (10.01 KB, patch) 2021-07-06 18:53 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (9.90 KB, patch) 2021-07-06 20:28 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Saam Barati

Comment 1 2021-07-06 11:09:56 PDT

weak cas test is also broken: O0: testAtomicWeakCAS<int8_t>()... ASSERTION FAILED: value[0] == static_cast<T>(100) (value[0] == -17, static_cast<T>(100) == 100) /Users/saambarati/WK/a/OpenSource/Source/JavaScriptCore/b3/testb3_8.cpp(148) : void testAtomicWeakCAS() [T = signed char]

Yusuke Suzuki

Comment 2 2021-07-06 18:46:52 PDT

Created attachment 432995 [details] Patch

Saam Barati

Comment 3 2021-07-06 18:49:43 PDT

Comment on attachment 432995 [details] Patch r=me, nice

Mark Lam

Comment 4 2021-07-06 18:50:49 PDT

EWS errors look real.

Yusuke Suzuki

Comment 5 2021-07-06 18:53:14 PDT

Created attachment 432996 [details] Patch