Bug 227662

Summary: [WebIDL] Properly validate and merge descriptors in [Replaceable] setter
Product: WebKit Reporter: Alexey Shvayka <ashvayka>
Component: BindingsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Trivial CC: cdumez, ews-watchlist, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Alexey Shvayka
Reported 2021-07-03 09:44:03 PDT
[WebIDL] Properly validate and merge descriptors in [Replaceable] setter
Attachments
Patch (22.71 KB, patch)
2021-07-03 10:05 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (22.78 KB, patch)
2021-07-05 06:48 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Shvayka
Comment 1 2021-07-03 10:05:02 PDT
Created attachment 432852 [details] Patch
Sam Weinig
Comment 2 2021-07-04 10:37:18 PDT
Comment on attachment 432852 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432852&action=review > Source/JavaScriptCore/runtime/JSObject.h:808 > + JS_EXPORT_PRIVATE bool createDataProperty(JSGlobalObject*, PropertyName, JSValue, bool shouldThrow); JS_EXPORT_PRIVATE is not needed when the function is inlined (as this one is).
Alexey Shvayka
Comment 3 2021-07-05 06:48:29 PDT
Created attachment 432881 [details] Patch Remove JS_EXPORT_PRIVATE to fix weak external symbol build error.
Radar WebKit Bug Importer
Comment 4 2021-07-10 09:45:15 PDT
<rdar://problem/80419243>
Alexey Shvayka
Comment 5 2021-07-23 18:19:28 PDT
Comment on attachment 432881 [details] Patch Thank you for review and helping out with the linker error, Sam!
EWS
Comment 6 2021-07-23 18:56:41 PDT
Committed r280280 (239938@main): <https://commits.webkit.org/239938@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432881 [details].
Note You need to log in before you can comment on or make changes to this bug.