| Summary: | [OpenSSL] Implement HKDF and PBKDF2 support | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||||
| Component: | Platform | Assignee: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ews-watchlist, Hironori.Fujii, jiewen_tan, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 206439 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Yoshiaki Jitsukawa
2021-07-03 00:57:17 PDT
Created attachment 433091 [details]
Patch
Created attachment 433097 [details]
Patch
Comment on attachment 433097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433097&action=review > Source/WebCore/crypto/openssl/CryptoAlgorithmPBKDF2OpenSSL.cpp:49 > + if (PKCS5_PBKDF2_HMAC((const char*)key.key().data(), key.key().size(), parameters.saltVector().data(), parameters.saltVector().size(), parameters.iterations, algorithm, output.size(), output.data()) <= 0) Even though WebKit code style guideline doesn't mention, some reviewer dislikes C-style case. You should use C++-style cast. Unfortunately, it's reinterpret_cast in this case. (In reply to Fujii Hironori from comment #3) > Comment on attachment 433097 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=433097&action=review > > > Source/WebCore/crypto/openssl/CryptoAlgorithmPBKDF2OpenSSL.cpp:49 > > + if (PKCS5_PBKDF2_HMAC((const char*)key.key().data(), key.key().size(), parameters.saltVector().data(), parameters.saltVector().size(), parameters.iterations, algorithm, output.size(), output.data()) <= 0) > > Even though WebKit code style guideline doesn't mention, some reviewer > dislikes C-style case. You should use C++-style cast. Unfortunately, it's > reinterpret_cast in this case. Got it, I'll fix it. Thank you. Created attachment 433109 [details]
Patch
Committed r279742 (239523@main): <https://commits.webkit.org/239523@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433109 [details]. |