Bug 227603

Summary: Provide SPI for clients to override just the contextmenu preview instead of the entire `UIContextMenuConfiguration`
Product: WebKit Reporter: Devin Rousso <hi>
Component: New BugsAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2021-07-01 17:11:32 PDT
.
Attachments
Patch (3.16 KB, patch)
2021-07-01 17:16 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.18 KB, patch)
2021-07-06 12:13 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-07-01 17:11:51 PDT
<rdar://problem/78832586>
Devin Rousso
Comment 2 2021-07-01 17:16:19 PDT
Created attachment 432753 [details] Patch
Wenson Hsieh
Comment 3 2021-07-01 17:39:13 PDT
Comment on attachment 432753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432753&action=review > Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:185 > +- (UIViewController *)_webView:(WKWebView *)webView contextMenuPreviewForElement:(WKContextMenuElementInfo *)elementInfo WK_API_AVAILABLE(ios(WK_IOS_TBA)); I'd maybe call this `-_webView:contextMenuContentPreviewForElement:` to match the wording in `UIContextMenuContentPreviewProvider`. Since this is going into iOS 15 and we've already replaced all the TBA macros for iOS 15/macOS 12, I think we should also make this `ios(15.0)` from the start.
Devin Rousso
Comment 4 2021-07-06 12:13:27 PDT
Created attachment 432959 [details] Patch
EWS
Comment 5 2021-07-06 15:34:51 PDT
Committed r279625 (239443@main): <https://commits.webkit.org/239443@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432959 [details].
Note You need to log in before you can comment on or make changes to this bug.