Bug 227578

Summary: REGRESSION(r278062): [Nicosia] Threaded rendering is broken since r278062
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: alicem, benjamin, bugs-noreply, cdumez, cmarcelo, eric.carlson, ews-watchlist, glenn, hta, jer.noble, mcatanzaro, philipj, sergio, simon.fraser, thorton, tommyw, webkit-bug-importer, youennf, zdobersek
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=226170
Attachments:
Description Flags
Patch
none
Patch ews-feeder: commit-queue-

Description Carlos Garcia Campos 2021-07-01 03:25:30 PDT 
We need to bring back things previously done by the base class and chain up to base class save/restore and being/end transparency.
Comment 1 Carlos Garcia Campos 2021-07-01 03:27:47 PDT 
Created attachment 432675 [details]
Patch
Comment 2 Carlos Garcia Campos 2021-07-01 04:20:53 PDT 
Committed r279462 (239318@main): <https://commits.webkit.org/239318@main>
Comment 3 Radar WebKit Bug Importer 2021-07-01 04:21:17 PDT 
<rdar://problem/80016872>
Comment 4 youenn fablet 2021-07-01 06:08:11 PDT 
Reopening to attach new patch.
Comment 5 youenn fablet 2021-07-01 06:08:15 PDT 
Created attachment 432684 [details]
Patch
Comment 6 Carlos Garcia Campos 2021-07-01 06:26:15 PDT 
Youenn, did you re-open the wrong bug? the patch looks unrelated.
Comment 7 youenn fablet 2021-07-01 06:27:36 PDT 
Hum, not sure why my patch was uploaded there. Thanks for noticing it!
Comment 8 youenn fablet 2021-07-01 06:32:51 PDT 
ChangeLog merge issue...
Comment 9 Tim Horton 2021-07-01 12:42:21 PDT 
Whoops, sorry! I was so close :)

Is this a special mode or different port? I did build + test webkitgtk (obviously, or the original patch would have been impossible), but didn't catch this.
Comment 10 Michael Catanzaro 2021-07-01 12:49:14 PDT 
Yeah, only GTK 4 and WPE use threaded rendering. GTK 3 does not because it's incompatible with the code for rendering scrollbars.

With GTK 4 we've just given up on themed scrollbars and have hardcoded a theme that's similar to GTK's default. Distros are going to hate this, but they haven't noticed yet....
Comment 11 Carlos Garcia Campos 2021-07-02 00:25:28 PDT 
(In reply to Michael Catanzaro from comment #10)
> Yeah, only GTK 4 and WPE use threaded rendering. GTK 3 does not because it's
> incompatible with the code for rendering scrollbars.

Not even WPE that defaults to 0 threads (so disabled). And the GTK4 bot was broken so didn't catch it either.

> With GTK 4 we've just given up on themed scrollbars and have hardcoded a
> theme that's similar to GTK's default. Distros are going to hate this, but
> they haven't noticed yet....