Bug 227534

Summary: Implement support for <dialog> element cancel event
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: DOMAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, clopez, dbarton, esprehn+autocc, ews-watchlist, fred.wang, gyuyoung.kim, kangil.han, kondapallykalyan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 227800, 228822    
Bug Blocks: 84635    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tim Nguyen (:ntim)
Reported 2021-06-30 09:37:39 PDT
Pressing "Esc" should "cancel" the dialog: e.g. close it, and emit a "cancel" event.
Attachments
Patch (80.57 KB, patch)
2021-07-12 06:20 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (92.45 KB, patch)
2021-08-05 10:42 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (96.35 KB, patch)
2021-08-05 13:46 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-06-30 09:48:53 PDT
This is only for modal dialogs.
Radar WebKit Bug Importer
Comment 2 2021-06-30 09:49:10 PDT
<rdar://problem/79971694>
Tim Nguyen (:ntim)
Comment 3 2021-07-12 06:20:24 PDT
Created attachment 433314 [details] Patch
Tim Nguyen (:ntim)
Comment 4 2021-08-05 10:42:48 PDT
Created attachment 435004 [details] Patch
EWS Watchlist
Comment 5 2021-08-05 10:43:45 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Tim Nguyen (:ntim)
Comment 6 2021-08-05 11:09:10 PDT
WPT PR: https://github.com/web-platform-tests/wpt/pull/29917
Chris Dumez
Comment 7 2021-08-05 12:49:17 PDT
Comment on attachment 435004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435004&action=review r=me > Source/WebCore/page/EventHandler.cpp:3514 > + if (HTMLDialogElement* activeModalDialog = m_frame.document()->activeModalDialog()) { auto*
Tim Nguyen (:ntim)
Comment 8 2021-08-05 13:46:08 PDT
Created attachment 435021 [details] Patch
Tim Nguyen (:ntim)
Comment 9 2021-08-05 13:57:04 PDT
Committed r280703 (240299@main): <https://commits.webkit.org/240299@main>
Note You need to log in before you can comment on or make changes to this bug.