[GTK][WPE] built-product-archive not running in SDK runtime

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Philippe Normand]

How can this work without running in the SDK runtime?

build-webkit ends up bind-mounting WebKitBuild/GTK/Release as WebKitBuild/Release in the runtime. But built-product-archive runs on the host and uses what is in WebKitBuild/Release... So is the zip file containing some old build from the jhbuild times?

I have a patch locally fixing this but first I want to confirm if there's an issue or something I missed with the current setup.

[Carlos Alberto Lopez Perez]

This is how this works:

* built-product-archive gets the build directory on the variable _configurationBuildDirectory after calling the function webkitBuildDirectoryForConfigurationAndPlatform(configuration, platform, fullPlatform)

* This function ends calling the following perl script:
perl Tools/Scripts/webkit-build-directory --gtk --release --configuration

Which on the case of a flatpak-enabled build ends returning this:
/home/igalia/clopez/webkit/webkit-flatpak/WebKitBuild/GTK/Release



It took me a while to discover this, is far from obvious. Seems this built-product-archive script would benefit from a refactoring and a bit of love, like for example stop using global variables on it.

[Philippe Normand]

That's the thing! Neither webkit-build-directory nor built-product-archive run from the SDK runtime!

[Carlos Alberto Lopez Perez]

(In reply to Philippe Normand from comment #2)
> That's the thing! Neither webkit-build-directory nor built-product-archive
> run from the SDK runtime!

That is right, but they don't need to do that AFAIK.

They only need to get the right build directory.

What built-product-archive does is simply to create a zip file with the contents of the WebKitBuild/GTK/Release directory
It just assumes the zip command is installed on the host (rather than in the container of the flatpak/SDK)

[Philippe Normand]

Ah, forgot that webkit-build-directory pulls in webkitdirs.pm which is flatpak-aware(?)