Bug 227468

Summary: NetworkProcessProxy::networkProcessDidTerminate() should copy process pools before iterating over them
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-06-28 15:54:50 PDT
NetworkProcessProxy::networkProcessDidTerminate() should copy process pools before iterating over them.
Attachments
Patch (1.65 KB, patch)
2021-06-28 15:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (17.21 KB, patch)
2021-06-28 16:27 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-06-28 15:55:58 PDT
Created attachment 432437 [details] Patch
Alex Christensen
Comment 2 2021-06-28 15:57:36 PDT
Comment on attachment 432437 [details] Patch WebProcessPool::allProcessPools should probably return a Vector<Ref<WebProcessPool>>
Chris Dumez
Comment 3 2021-06-28 15:59:24 PDT
(In reply to Alex Christensen from comment #2) > Comment on attachment 432437 [details] > Patch > > WebProcessPool::allProcessPools should probably return a > Vector<Ref<WebProcessPool>> Seems like this would be unnecessarily inefficient for call sites that do not need copying/ref'ing (e.g. the ones that only do IPC).
Alex Christensen
Comment 4 2021-06-28 15:59:51 PDT
Comment on attachment 432437 [details] Patch It would also be safer.
Chris Dumez
Comment 5 2021-06-28 16:27:34 PDT
Created attachment 432440 [details] Patch
EWS
Comment 6 2021-06-28 17:25:02 PDT
Committed r279354 (239222@main): <https://commits.webkit.org/239222@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432440 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-28 17:26:25 PDT
<rdar://problem/79890078>
Note You need to log in before you can comment on or make changes to this bug.