Bug 227381

Summary: REGRESSION (r279208): Windows build failing with errors in CoreMediaSoftLink
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: MediaAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, changseok, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, kangil.han, philipj, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=227250
Attachments:
Description Flags
Revert patch
ews-feeder: commit-queue-
Patch none

Description Ryan Haddad 2021-06-24 17:32:26 PDT 
The Windows build was broken by https://trac.webkit.org/changeset/279208/webkit
C:\cygwin\home\buildbot\worker\win10-debug\build\Source\WebCore\PAL\pal\cf\CoreMediaSoftLink.cpp(203,1): error C2061: syntax error: identifier 'CMClockRef' [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\PAL\pal\PAL.vcxproj]
C:\cygwin\home\buildbot\worker\win10-debug\build\Source\WebCore\PAL\pal\cf\CoreMediaSoftLink.h(348,1): error C2061: syntax error: identifier 'CMClockRef' (compiling source file C:\cygwin\home\buildbot\worker\win10-debug\build\Source\WebCore\PAL\pal\avfoundation\MediaTimeAVFoundation.cpp) [C:\cygwin\home\buildbot\worker\win10-debug\build\WebKitBuild\Debug\Source\WebCore\PAL\pal\PAL.vcxproj]
https://build.webkit.org/#/builders/56/builds/3037/steps/8/logs/stdio
Comment 1 Ryan Haddad 2021-06-25 09:19:41 PDT 
Created attachment 432279 [details]
Revert patch
Comment 2 Ryan Haddad 2021-06-25 09:37:08 PDT 
Created attachment 432281 [details]
Patch
Comment 3 EWS 2021-06-25 10:12:19 PDT 
Committed r279288 (239167@main): <https://commits.webkit.org/239167@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432281 [details].
Comment 4 Radar WebKit Bug Importer 2021-06-25 10:13:19 PDT 
<rdar://problem/79784193>