Bug 227377

Summary: Remove references to order files
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: REOPENED    
Severity: Normal CC: commit-queue, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 227402    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Sihui Liu
Reported 2021-06-24 14:21:42 PDT
rdar://76070556
Attachments
Patch (6.47 KB, patch)
2021-06-24 14:26 PDT, Sihui Liu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2021-06-24 14:26:33 PDT
Created attachment 432215 [details] Patch
Mark Lam
Comment 2 2021-06-24 14:30:03 PDT
Comment on attachment 432215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432215&action=review > Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:37 > SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,JavaScriptCore.order; Do we need it for Mac? Or can we purge those as well?
Sihui Liu
Comment 3 2021-06-24 14:43:48 PDT
(In reply to Mark Lam from comment #2) > Comment on attachment 432215 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432215&action=review > > > Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:37 > > SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,JavaScriptCore.order; > > Do we need it for Mac? Or can we purge those as well? This (rdar://76070556) is only available on iOS now.
Mark Lam
Comment 4 2021-06-24 14:53:26 PDT
Comment on attachment 432215 [details] Patch r=me if EWS bots are green.
EWS
Comment 5 2021-06-24 20:30:07 PDT
Committed r279266 (239145@main): <https://commits.webkit.org/239145@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432215 [details].
WebKit Commit Bot
Comment 6 2021-06-25 08:04:12 PDT
Re-opened since this is blocked by bug 227402
Note You need to log in before you can comment on or make changes to this bug.