Bug 227377

Summary: Remove references to order files
Product: WebKit Reporter: Sihui Liu <sihui_liu>
Component: New BugsAssignee: Sihui Liu <sihui_liu>
Status: REOPENED ---    
Severity: Normal CC: commit-queue, ews-watchlist, ggaren, keith_miller, mark.lam, msaboff, sbarati, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 227402    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Sihui Liu 2021-06-24 14:21:42 PDT
rdar://76070556
Comment 1 Sihui Liu 2021-06-24 14:26:33 PDT
Created attachment 432215 [details]
Patch
Comment 2 Mark Lam 2021-06-24 14:30:03 PDT
Comment on attachment 432215 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432215&action=review

> Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:37
>  SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,JavaScriptCore.order;

Do we need it for Mac?  Or can we purge those as well?
Comment 3 Sihui Liu 2021-06-24 14:43:48 PDT
(In reply to Mark Lam from comment #2)
> Comment on attachment 432215 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432215&action=review
> 
> > Source/JavaScriptCore/Configurations/JavaScriptCore.xcconfig:37
> >  SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,JavaScriptCore.order;
> 
> Do we need it for Mac?  Or can we purge those as well?

This (rdar://76070556) is only available on iOS now.
Comment 4 Mark Lam 2021-06-24 14:53:26 PDT
Comment on attachment 432215 [details]
Patch

r=me if EWS bots are green.
Comment 5 EWS 2021-06-24 20:30:07 PDT
Committed r279266 (239145@main): <https://commits.webkit.org/239145@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432215 [details].
Comment 6 WebKit Commit Bot 2021-06-25 08:04:12 PDT
Re-opened since this is blocked by bug 227402