Summary: | WebKitGTK fails to handle some keypresses when built with the GTK Quartz backend on macOS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | discuss | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | berto, bugs-noreply, cgarcia, clopez, ews-watchlist, gustavo | ||||
Priority: | P2 | ||||||
Version: | WebKit Local Build | ||||||
Hardware: | Mac (Intel) | ||||||
OS: | macOS 10.14 | ||||||
Attachments: |
|
Description
discuss
2021-06-24 10:00:54 PDT
Created attachment 432180 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API I've uploaded a patch that I'm considering applying to the downstream macOS build of WebKitGTK in the Nix package manager for the time being. It seems to fix the problem, but I'm not too sure whether this is a good idea or not. Would applying this patch have any obvious unintended side effects? Any help would be appreciated. (In reply to discuss from comment #3) > I've uploaded a patch that I'm considering applying to the downstream macOS > build of WebKitGTK in the Nix package manager for the time being. It seems > to fix the problem, but I'm not too sure whether this is a good idea or not. > Would applying this patch have any obvious unintended side effects? Any help > would be appreciated. It seems it has unintended side effects. As far as I can see this patch made the WebKitGTK API tests to fail on the CI, check the red bubble above -> https://ews-build.webkit.org/#/builders/34/builds/38608 |