Bug 227344

Summary: [GTK][WPE] Check GApplication has a valid ID before trying to create the flatpack info
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mcatanzaro: review-
Patch mcatanzaro: review+, mcatanzaro: commit-queue-

Carlos Garcia Campos
Reported 2021-06-24 02:43:53 PDT
(MiniBrowser:49675): GLib-CRITICAL **: 11:38:50.163: g_key_file_set_string: assertion 'string != NULL' failed
Attachments
Patch (1.73 KB, patch)
2021-06-24 02:45 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2021-06-24 02:46 PDT, Carlos Garcia Campos 		mcatanzaro: review-
DetailsFormatted DiffDiff
Patch (2.08 KB, patch)
2021-06-28 05:09 PDT, Carlos Garcia Campos 		mcatanzaro: review+
mcatanzaro: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2021-06-24 02:45:22 PDT
Created attachment 432144 [details] Patch
Carlos Garcia Campos
Comment 2 2021-06-24 02:46:10 PDT
Created attachment 432145 [details] Patch
Michael Catanzaro
Comment 3 2021-06-24 13:40:14 PDT
Comment on attachment 432145 [details] Patch Patrick noticed that this will cause portals to think the application is not sandboxed. We should instead replaced the early return with a g_error() explaining that the sandbox cannot be used without running a GApplication instance with a valid app ID.
Carlos Garcia Campos
Comment 4 2021-06-28 05:09:23 PDT
Created attachment 432383 [details] Patch
Michael Catanzaro
Comment 5 2021-06-28 07:15:59 PDT
Comment on attachment 432383 [details] Patch OK, but I would remove the 'return -1' lines before landing, because they are now unreachable.
Carlos Garcia Campos
Comment 6 2021-06-29 02:12:40 PDT
Committed r279369 (239235@main): <https://commits.webkit.org/239235@main>
Note You need to log in before you can comment on or make changes to this bug.