Bug 227328

Summary: Base Options::useWebAssemblyFastMemory's default value on Gigacage::hasCapacityToUseLargeGigacage.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch. saam: review+

Mark Lam
Reported 2021-06-23 16:09:58 PDT
Gigacage::hasCapacityToUseLargeGigacage is determined based on EFFECTIVE_ADDRESS_WIDTH. If we have enough address range to potentially use a large gigacage, then we have enough address range to useWebAssemblyFastMemory.
Attachments
proposed patch. (6.36 KB, patch)
2021-06-23 16:17 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
proposed patch. (6.58 KB, patch)
2021-06-23 16:18 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-06-23 16:17:04 PDT
Created attachment 432103 [details] proposed patch.
Mark Lam
Comment 2 2021-06-23 16:18:40 PDT
Created attachment 432104 [details] proposed patch.
Mark Lam
Comment 3 2021-06-23 21:27:59 PDT
Thanks for the review. Landed in r279209: <http://trac.webkit.org/r279209>.
Radar WebKit Bug Importer
Comment 4 2021-06-23 21:28:19 PDT
<rdar://problem/79708581>
Note You need to log in before you can comment on or make changes to this bug.